This repository was archived by the owner on Apr 18, 2025. It is now read-only.
NW6 | Pedram Amani | Module-JS1 | Week4 #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudopilot
approved these changes
May 15, 2024
There was a problem hiding this comment.
This is really great job @pedram-am ! 🥇
I left few comments for you, but still it's done properly.
| @@ -1,3 +1,47 @@ | |||
| // Given a positive integer num, | |||
| // When the isPrime function is called with num as input, | |||
| // Then it should return a boolean representing whether the num is prime | |||
|
|
|||
| function isPrime(num) { | |||
| if (isNaN(num) || num <= 0 || Number.isInteger(num) !== true) { | |||
There was a problem hiding this comment.
Just small refactoring is possible here: !Number.isInteger(num) instead of Number.isInteger(num) !== true
| throw new Error("The second parameter must be a number!"); | ||
| } | ||
|
|
||
| if (Number.isInteger(count) !== true || count < 0) { |
There was a problem hiding this comment.
Same comment as above about Number.isInteger(num) !== true
Comment on lines
+40
to
+43
| let result = ""; | ||
| for (let i = 0; i < count; i++) { | ||
| result += str; | ||
| } |
There was a problem hiding this comment.
This must work great! Though we may use string method repeat instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
JavaScript 1 - Week 4 exercises
Questions
Ask any questions you have for your reviewer.