London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Implement unfollow#173
Open
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Implement unfollow#173aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
aydaeslami
added
📅 Sprint 1
OracPrime
suggested changes
Mar 3, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
One tiny tweak needed, otherwise very good
| type_check_error = verify_request_fields({"username": str, "password": str}) | ||
| if type_check_error is not None: | ||
| return type_check_error | ||
| assert request.json is not None |
There was a problem hiding this comment.
This is a bit unfriendly: is request.json is None this will probably give a 500 internal server error. Raising an explicit bad request error, with a message, would be better
github-project-automation
bot
moved this from Backlog
to In Progress
in Purple Forest Kanban
OracPrime
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Add unfollow functionality to allow users to unfollow previously followed users. Updates backend endpoint, API service, and profile UI to support Follow/Unfollow toggle.