generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 430
Glasgow | 26-ITP-Jan | Joma Alrzini | Sprint 2 | Form- Control #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alrzini2025
wants to merge
8
commits into
CodeYourFuture:main
Choose a base branch
from
Alrzini2025:Form-Control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e6fbee9
I am doing Form by HTML
Alrzini2025 39a7007
This is my coursework for Form Control
Alrzini2025 40b453b
chnage
Alrzini2025 02a11d9
I have made chage to allow name have charecters
Alrzini2025 ae64337
I have made required changes
Alrzini2025 cc586bb
putting Wireframe back
Alrzini2025 bffc39b
putting bake Wireframe
Alrzini2025 b65c823
I made changes in mane pattern
Alrzini2025 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,77 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
|
|
||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>T-Shirt Order</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- Customer Details --> | ||
| <fieldset> | ||
| <legend>Confirm Your Details</legend> | ||
|
|
||
| <!-- Name: letters and spaces only --> | ||
| <label for="name">Full Name</label> | ||
| <input type="text" id="name" name="name" required pattern="[A-Za-zÀ-ÿ\s'-]{2,}" | ||
| title="Please enter a valid name (letters and spaces only)"> | ||
|
|
||
| <!-- Email --> | ||
| <label for="email">Email Address</label> | ||
| <input type="email" id="email" name="email" required> | ||
| </fieldset> | ||
|
|
||
| <!-- Colour Selection --> | ||
| <fieldset> | ||
| <legend>T-Shirt Colour</legend> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="Black" required> | ||
| Black | ||
| </label> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="White"> | ||
| White | ||
| </label> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="Blue"> | ||
| Blue | ||
| </label> | ||
| </fieldset> | ||
|
|
||
| <!-- Size Selection --> | ||
| <fieldset> | ||
| <legend>T-Shirt Size</legend> | ||
|
|
||
| <label for="size">Choose a size</label> | ||
| <select id="size" name="size" required> | ||
| <option value="">-- Select Size --</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </fieldset> | ||
|
|
||
| <button type="submit">Place Order</button> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>Joma Alrzini</h2> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this pattern will indeed accept much more names than previous, but it still have limitations, for example it won't accept Chinese names.
My main take, though, is we should stick to the initial task. Initial task demands us to have a limit of 2 characters only without specifying limits for the character types i.e. we should not have regex limit in this case at all.