Skip to content

[Fix] Various fixes #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

[Fix] Various fixes #4411

wants to merge 4 commits into from

Conversation

abaicus
Copy link
Collaborator

@abaicus abaicus commented May 14, 2025

Summary

  1. Fixes issue with Elementor Pro Header & Footer builder breaking theme markup - Custom Header in Elementor Pro affects the shop page layout #4349
  2. Fixes deprecation notice on nullable parameter - Deprecated notice in PHP 8.4 #4393;
  3. Fixes issue with custom layouts notice going off-screen - Custom Layouts notice goes down the screen, when other plugins have menu items in the WP menu #4391;

Will affect visual aspect of the product

NO

Test instructions

1. #4349

  • Install Elementor, Elementor Pro & Woocommerce;
  • Make sure you have a basic shop set up;
  • Go to Templates > Theme Builder;
  • Create a Header (maybe test with footer as well) - you can set it to display sitewide, or any other way to accomodate testing;
  • Layout on Shop should work as expected;
  • Layout on Blog Archive when using a sidebar;

2. #4393

  • Use an instance with PHP v8.4 and WP_DEBUG enabled;
  • No notice should be displayed;
  • Customizer should work fine - especially the Header/Footer builder components settings (you can check 1-2 components);

3. #4349

  • Install this plugin and activate it: loads-of-menu-pages.zip
  • Go into the Dashboard > Loads of Menu Pages page - here you can set up to 100 dummy dashboard pages;
  • Set an arbitrary number (enough to be able to scroll the dashboard);
  • Go to the custom layouts page (the one with the upsell);
  • The modal should stay into view when scrolling

Check before Pull Request is ready:

Closes #4349.
Closes #4393;
Closes #4391;

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label May 14, 2025
@pirate-bot
Copy link
Collaborator

pirate-bot commented May 14, 2025

Plugin build for b74bb3a is ready 🛎️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants