Improved condition handling#627
Open
girishpanchal30 wants to merge 3 commits into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Tip You can preview the changes in the Playground Plugin build for c4d08b6 is ready 🛎️!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts PPOM’s conditional-logic behavior so fields configured with bound: Any don’t remain “locked” once any rule matches, and it also normalizes PPOM_Meta::inline_js() to return an empty string instead of null when no meta/settings exist.
Changes:
- Update conditional-logic evaluation for
bound === 'Any'to clearppom-locked-*classes when rules match. - Normalize
inline_js()early returns fromnullto''for more consistent string handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| js/ppom-conditions-v2.js | Updates Any binding handling by removing ppom-locked-* classes when conditions match. |
| classes/ppom.class.php | Changes inline_js() early returns from null to ''. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soare-Robert-Daniel
approved these changes
May 28, 2026
Soare-Robert-Daniel
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed all
ppom-locked-*classes from the conditional fields when setting the rule for any matches. This will make sure that the fields will be shown when any of the conditions are matched.Check before Pull Request is ready:
Closes https://github.com/Codeinwp/ppom-pro/issues/714