Fixed fatal error#628
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
Contributor
|
Tip You can preview the changes in the Playground Plugin build for 8333074 is ready 🛎️!
|
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces stripcslashes() calls in Engine::get_field_prices() with wp_unslash() so array-shaped posted PPOM field values (e.g. checkboxes/multi-selects) no longer trigger a TypeError on PHP 8, fixing the site-breaking fatal reported in #617. wp_unslash() recursively handles strings and arrays, matching the WordPress-standard unslashing pattern already used elsewhere in this codebase (e.g. CartHandler.php:409, ProductHandler.php:220).
Changes:
- Use
wp_unslash()for the per-field posted$valuenormalization inget_field_prices(). - Use
wp_unslash()for thebulkquantityfield_meta['options']JSON decode. - Use
wp_unslash()for select/radio and checkbox option-value comparisons.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soare-Robert-Daniel
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Used
wp_unslashinstead ofstripslashesto remove the slashes.Check before Pull Request is ready:
Closes #617