fix(api-dto): import Dto.Shared.projitems so the package actually packs - #14
Merged
Conversation
mass-release.yml stopped on api-dto with NU5026:
The file '.../Codout.Framework.Api.Dto/bin/Release/netstandard2.1/
Codout.Framework.Api.Dto.dll' to be packed was not found on disk.
Root cause: Codout.Framework.Api.Dto/ contains only the .csproj — no
.cs files anywhere. The shared types (Dto, IDto, EntityDto<T>,
IEntityDto<T>) live in Codout.Framework.Dto.Shared/ and are pulled
into consumer csprojs via a Shared Project Import. Codout.Framework
.Application and Codout.Framework.Api.Client both do this:
<Import Project="..\Codout.Framework.Dto.Shared\
Codout.Framework.Dto.projitems" Label="Shared" />
Codout.Framework.Api.Dto.csproj never had that line. Build produced
no assembly, and pack had nothing to package.
This fix adds the same Import line. No version bump: the broken 6.3.0
was never produced (pack failed), so the version slot is still free.
https://claude.ai/code/session_015jxScBEvdKkRwGvJTgK5Py
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
mass-release.ymlfalhou no pack doapi-dto:Root cause
A pasta
Codout.Framework.Api.Dto/tem só o.csproj— zero arquivos.cs. Os tipos compartilhados do DTO (Dto,IDto,EntityDto<T>,IEntityDto<T>) moram emCodout.Framework.Dto.Shared/como um Shared Project (.shproj+.projitems), e cada consumer puxa via<Import>no csproj.Confirmação olhando os outros consumidores:
Codout.Framework.Api.Dto.csprojsimplesmente não tinha essa linha. Build não gerava DLL → pack não tinha o que empacotar →NU5026.Confirmei que os outros 3 csproj que aparecem "vazios" no diretório raiz (
Common,Domain,Mailer) não estão nesta situação — todos têm.csem subpastas e o SDK pega via glob implícito.Fix
Uma linha no
Codout.Framework.Api.Dto.csproj:Mais um comentário explicando por quê, pra próximo desenvolvedor não remover por engano.
Versão
Sem bump. O
6.3.0doapi-dtonunca foi efetivamente publicado (pack falhou, nupkg não foi gerado, nada subiu pro NuGet). O slot 6.3.0 continua livre — este PR só faz o pacote ser produzível pela primeira vez.Sequência depois do merge
confirm:PUBLISHinclude_mcp: desmarcadodry_run: marcado (primeira passada)dry_rundesmarcado pra publicar.Test plan
dotnet pack Codout.Framework.Api.Dto/Codout.Framework.Api.Dto.csprojproduz.nupkgsem erromass-release.ymlchega ao final sem NU5026codout-framework-all-nupkgtem 24.nupkg(incluindoCodout.Framework.Api.Dto.6.3.0.nupkg)--skip-duplicate)https://claude.ai/code/session_015jxScBEvdKkRwGvJTgK5Py
Generated by Claude Code