Fix DeprecationError from ModuleSpec.loader.load_module in Red.load_extension
#5956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We currently have some other plans for changes to the import system (related to #2446) so I'm going to mark this as Blocked for now and we will see if it's still needed once we either make those changes or decide to defer them. |
Zephyrkul
reviewed
Jan 6, 2023
Kuro-Rui
force-pushed
the
use_exec_module
branch
from
5315a95 to
0a5aa94
Compare
github-actions
bot
added
the
Category: Core - Bot Class
Contributor
Author
|
Sorry, closed by accident because of conflicts 😅 |
Kuro-Rui
changed the title
ModuleSpec.loader.load_module in Red.load_extension
Contributor
Author
|
Recently found a bug, apparently if you load warnings ( |
Contributor
Author
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This PR changes
load_moduleinRed.load_extensiontoexec_moduleto give support for Python 3.12Have the changes in this PR been tested?
Yes