Fix checks not properly handling Group commands type#6577
Open
Sutaai wants to merge 1 commit intoCog-Creators:V3/developfrom
Open
Fix checks not properly handling Group commands type#6577Sutaai wants to merge 1 commit intoCog-Creators:V3/developfrom
Sutaai wants to merge 1 commit intoCog-Creators:V3/developfrom
Conversation
Member
|
I would be interested to know if swapping the order of your checks on the group would make the error go away - put the |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of the changes
This PR propose to add the type
Groupto the type variable used inRequires.get_decorator(Which is used by Red's checks).This was made as creating a command group, in addition of one of Red's provided check, would alert Pylance of incorrect type, expecting type
Commandonly.Before
After


The correct type is now reflected.
Same issue and fix apply for
@commands.hybrid_groupHave the changes in this PR been tested?
Yes