Skip to content

Remove unused direct dependencies orjson, Brotli and zstandard from configuration files#6587

Closed
karyotakisg wants to merge 1 commit intoCog-Creators:V3/developfrom
karyotakisg:V3/develop
Closed

Remove unused direct dependencies orjson, Brotli and zstandard from configuration files#6587
karyotakisg wants to merge 1 commit intoCog-Creators:V3/developfrom
karyotakisg:V3/develop

Conversation

@karyotakisg
Copy link
Copy Markdown

Description of the changes

As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.

Specifically, the direct dependencies orjson, zstandard and Brotli are specified as a requirement in the base.in and base.txt files, when in reality they are not needed.

Hope this is helpful!

Best regards

Have the changes in this PR been tested?

Yes, tox was used.

@github-actions github-actions bot added the Category: Meta This is related to the repository maintenance. label Jul 16, 2025
@Flame442
Copy link
Copy Markdown
Member

For brotli, aiohttp considers it an optional dependency and gains increased performance/functionality when it is installed. For orjson, discord.py considers it an optional dependency and gains increased performance parsing data from the discord API. I don't know for certain for z standard, but I imagine we have it for a similar reason as the other two. It could potentially be documented better that they are not unused dependencies.

@Jackenmen
Copy link
Copy Markdown
Member

These are used - not by our code directly but by our dependencies. They don't get added as transitive dependencies by pip-compile because they're optional dependencies and we don't list the relevant extras they're included in as those extras don't allow for the same granularity (i.e. I can't include aiohttp[speedups] without also including aiodns, which we don't want).
Closing as invalid.

@Jackenmen Jackenmen closed this Jul 16, 2025
@Jackenmen Jackenmen added the Closed: Invalid There is no action to be taken in response to this issue. label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Meta This is related to the repository maintenance. Closed: Invalid There is no action to be taken in response to this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants