Remove unused direct dependencies orjson, Brotli and zstandard from configuration files#6587
Remove unused direct dependencies orjson, Brotli and zstandard from configuration files#6587karyotakisg wants to merge 1 commit intoCog-Creators:V3/developfrom
Conversation
|
For brotli, aiohttp considers it an optional dependency and gains increased performance/functionality when it is installed. For orjson, discord.py considers it an optional dependency and gains increased performance parsing data from the discord API. I don't know for certain for z standard, but I imagine we have it for a similar reason as the other two. It could potentially be documented better that they are not unused dependencies. |
|
These are used - not by our code directly but by our dependencies. They don't get added as transitive dependencies by pip-compile because they're optional dependencies and we don't list the relevant extras they're included in as those extras don't allow for the same granularity (i.e. I can't include aiohttp[speedups] without also including aiodns, which we don't want). |
Description of the changes
As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.
Specifically, the direct dependencies
orjson,zstandardandBrotliare specified as a requirement in thebase.inandbase.txtfiles, when in reality they are not needed.Hope this is helpful!
Best regards
Have the changes in this PR been tested?
Yes,
toxwas used.