This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Merged
Conversation
Member
Collaborator
Author
|
Just checked - and with the latest change - read the docs builds are fine again. |
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jul 1, 2025
* CU-8698x2k5b: Add simple pyproject.toml * CU-8698x2k5b: Make ReadTheDocs install with pip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadTheDocs builds are now failing.
Turns out that's because
pip==25.1now removes the build process that's used on there (see release notes).So we are now forced to use a minimal
pyproject.toml.Though notably, we can get away with still using setup.py for most of the installation process.
So this PR will make that change.
The docs builds should work with this change alone. But I will - of course - make sure they do be enabling this branch as a version temporarily.