This repository was archived by the owner on Jul 28, 2025. It is now read-only.
CU-86995mmb6 Fix some RelCAT typing issues#542
Merged
Conversation
Member
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jul 1, 2025
* CU-86995mmb6: Fix typing issues with modern bert config * CU-86995mmb6: Fix issue with llama tokenizer wrapper * CU-86995mmb6: Fix typing issues with llama config * CU-86995mmb6: Make bert model config types explicit as well * CU-86995mmb6: Remove excessive/unncessary type hints * CU-86995mmb6: Remove unncessary type ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some typing issues that were resolved with this PR.
The gist of it has to do with specific models (i.e ModernBert or Llama) requiring model-specific configs isntead of the baseclass of
PretrainedConfig.Though the fix does need a
castoperation, I moved all those jointly intomedcat.utils.relation_extraction.models.Though there's also casting of loaded config for each (Bert, ModernBert, Llama) due to the method signature of
.from_pretrainedand.from_json_filereturning aPretrainedConfigrather than the specific one that it was called on. In reality, the calling class is returned anyway (since the implicitclsis initialised in both cases).