Fix macOS file association for .cgt files #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CFBundleDocumentTypes to Info.plist to register .cgt file association - Fix argument passing in cogtoolstart script (use "$@" instead of $*) - Add test to verify file association and argument parsing works correctly - Ensure PSN arguments from macOS are properly ignored Fixes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #20 by implementing proper file association for .cgt files on macOS.
Changes Made
CFBundleDocumentTypessection to register CogTool as the editor for .cgt files"$@"instead of$*for proper argument passing with spaces in filenamesTechnical Details
The root cause was that arguments weren't being passed correctly from macOS through the shell script to the Java application. The fix ensures:
Testing
Added
FileAssociationTest.javawhich verifies:The test passes successfully, confirming the fix works as intended.
Fixes #20
@justingeeslin can click here to continue refining the PR