Convert 17-0574 (rev 2): read Designer WorkFlow exports, re-pair to Forms_17-0574 (AEM to Quad).xml, re-pin metrics - #5
Merged
Conversation
…o Forms_17-0574 (AEM to Quad).xml
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second convert-form pass for
17-0574with a new reference export,Forms_17-0574 (AEM to Quad).xml, replacing17-0574.xml. The form is still not converted and not ready: G3 and G4 fail, G5/G6 are external, all three decisions remainproposed.Input note: the session was again launched as
form_id: 17-2574; the XDP is170574.xdpand pairs.yaml pairs it as17-0574, so this PR is for17-0574. Nothing was renamed (the target file keeps its supplied name, spaces and parentheses included).What changed and why:
<WorkFlow version="17.0.436.3">withProperty/Connect/Output/ExtWfdImplchildren and oneLayoutmodule whose nested<Layout>holds the record list the inventory expects.target_inventory.inventory()iterated the root directly, so G4 saw 0 controls/variables and G5 lint produced 200 bogusIMP-003. Reusable fix (rule 8, not a per-form patch):<Layout>; multiple modules and unknown roots raise.src/fixtures/pairs.yaml: 17-0574layout_xmlre-paired to the new file (sha2567202b804…, 4,089,931 B); note records that the earlier17-0574.xmlwas a different revision and is superseded.src/decisions/17-0574.yaml: no new findings; D-001 rationale now cites both exports (the new one also has one*_BarcodeFlowArea_*per page and noNB6001variable). Still 3proposed,decided_by/decided_onnull.knowledge/quadient-designer.md: the "full WFD vs partial layout export" question is now answered by observation (both variants exist and are read).tests/test_golden.py17-0574 re-pins: G0fail→pass; field match0.5041→0.6341; exact-name0.122→0.0894; static text0.7707→0.9608; target controls271→74; data variables314→2494. 18-1026 untouched.may_commit_artifacts: no); hashes verified.Readiness (
out/readiness.json, 17-0574)G2-UNKNOWNSTATICG3-DRAFT-RULE(major)G4-UNMATCHEDRouted findings by action:
manual_design3 (G3-UNBOUNDx3, the footer PDF417 barcodes). NoG3-STALE-DECISION. Minor, not routable:G3-DUPNAMEx25.Scripts (classified, never executed): 48 total, 100% mechanically transferable —
mutual_exclusion19,visibility16,conditional_clear10,uppercase3. None manual.Draft rules the form depends on:
BND-04, FLD-01, OBJ-02, OBJ-05, OBJ-08, OBJ-12.Why G4 is still under the floor with a matching revision: 45/123 fields find no target by name; the export carries 2,494 data variables (most under module/system groups) against 74 FormControls, and exact-name agreement is 9%, so the dictionary (BND-05) rather than fuzzy matching has to close the gap. No thresholds changed.
People / external gates
handoff/17-0574/: plan sha25666bc8e7c…unchanged,CimBuildPlanImport.groovy, filtered decisions,CHECKLIST.mdwith the migration-stack v17.0.30 deploy sequence) andout/readiness.mdare attached to the session;handoff/is gitignored.Checks
ruff check .,ruff format --check .clean;pytest -q96 passed / 7 skipped (18-1721 artifacts absent);python -m tools.pipeline -o out/exit 0.Clearance note: derived metrics and SOM paths from a partner-built test form, consistent with existing records; clearance status per
knowledge/customer-clearance-boundariesremains TBD.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/060b9626e9ad430186f22f341a34278b
Open in Devin Desktop: https://partner-workshops.devinenterprise.com/desktop/session/060b9626e9ad430186f22f341a34278b?variant=devin
Requested by: @sumitshatwara