Convert 18-1721: pair with Forms_18-1721 (AEM to Quad).xml, support layout-only pairs, route 89 G3 findings (deferred on G0 drift) - #8
Merged
Conversation
…ith Forms_18-1721 (AEM to Quad).xml
…rmation), pin golden metrics, prepare Designer handoff
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This was referenced Sep 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert-form session for 18-1721 (
181721.xdp) against the Designer WorkFlow exportForms_18-1721 (AEM to Quad).xml. No composed PDF was supplied, which the code previously could not represent, so this PR also adds the reusable layout-only reference pair case. The form is not converted and not ready: G0 fails GOV-01, so no target names are proposed and all binding findings are routed asdefer.Layout-only reference pairs (reusable fix)
pairs.yamlnow allowstarget.composed_pdf: nullwhilelayout_xmlis required for any non-null target:Tests cover the loader, G0 and the pipeline path. Thresholds, exit codes and loader checks are unchanged.
Gate report for 18-1721 (from
out/readiness.json)G0-REVISION-DRIFT);G0-NO-PDFinfoG2-UNKNOWNSTATICG4-UNMATCHED, sections matched 0/5, target 73 FormControls / 449 data variablesWhy G0 fails and what it implies. The 12 target-only tokens are a company name/address footer block, not form content, which suggests a footer added in Designer rather than a different form revision — but GOV-01 is the rule and only a human can confirm the pairing. Per
convert-xdp-formstep 4, target names are therefore not proposed in this PR (no crosswalk or elements rows). Eachdeferrecord carries the candidateDef.Data/SubTree0/*variable observed in the export as evidence so a follow-up session can turn them intoproposedcrosswalk rows once the pairing is confirmed.Decisions (
src/decisions/18-1721.yaml, allproposed, session linked): 89 recordsdefer77 — 69G3-UNBOUNDfields with a candidate target variable, 8G3-UNBOUNDtelephone parts (target has 2Telephone*variables per page vs 4 numeric parts in the XDP)keep_unbound10 — 8G3-NONAMEtelephone parts (captions are(/)mask punctuation), 2 page-number fieldstranslate_script2 —VAL-SCRIPT-MANUALonPage1.CurrentPage/Page1.PageCount(readyscripts arexfa.layout.page(this)/xfa.layout.pageCount()→ Designer page-number/page-count system variables; exact names for the designer to confirm)Scripts by class: 4 total —
conditional_clear2 (date-format alert on bothDateField1),unknown2 (the page-number scripts above). 50% mechanically transferable.Draft rules depended on: BND-04, FLD-01, OBJ-02, OBJ-05, OBJ-12, VAL-06. G3 stays failed while decisions are
proposedand these rules aredraft.Reviewers: decision reviewer — none named; Designer importer — none named. G5 and G6 are external.
Handoff package
handoff/18-1721/—18-1721.plan.json(sha2564e852e2b…4f50c),CimBuildPlanImport.groovy,decisions.manual.yaml(77 defer records),CHECKLIST.md. Plan facts: 77 variables (all unresolved pending pairing confirmation), 109 decisions_required, 2 skipped controls (bothDateField1image controls, UNS-09).Verification
ruff check .,ruff format --check .,pytest -q(111 passed),python -m tools.pipeline -o out/exit 0. Golden pins for 18-1721 updated fromreadiness.json; other forms' pins unchanged. No raw artifacts orout/committed.Open question for the reviewer
Is the address footer in
Forms_18-1721 (AEM to Quad).xmla Designer addition to the same revision (0810) as181721.xdp? If yes, the 77deferrecords can becomebind_to_element+ crosswalk proposals in a follow-up session; if no, the matching XDP revision is needed.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/060b9626e9ad430186f22f341a34278b
Open in Devin Desktop: https://partner-workshops.devinenterprise.com/desktop/session/060b9626e9ad430186f22f341a34278b?variant=devin
Requested by: @sumitshatwara