DJ-69: Migrate CBSTM03A statement batch to Java + Spring Boot statement viewer - #234
Open
devin-ai-integration[bot] wants to merge 8 commits into
Open
devin-ai-integration[bot] wants to merge 8 commits into
devin-ai-integration[bot] wants to merge 8 commits into
Conversation
…ation' into devin/1785419531-dj69-statement-modernization
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Jira DJ-69: modernizes the CardDemo statement batch (
app/cbl/CBSTM03A.CBL+app/cbl/CBSTM03B.CBL) into a new Java 17 Maven modulecarddemo-java, plus a Spring Boot web statement viewer replacing the COBOL-generated HTML statements. Built by two parallel workstreams (batch migration + viewer) against a locked statement JSON contract, then merged and wired end-to-end.carddemo-java/docs/statement-contract.json+statement-contract.schema.json) — canonical statement JSON per DJ-69:{accountId, customer{firstName,lastName,addressLines[]}, cardNumber (masked), transactions[{transactionId,description,amount}], totalAmount}.com.carddemo.statement.generator/parser/model) — ports the1000-MAINLINEjoin: iteratecardxref.txt, look up customer (custdata.txt) and account (acctdata.txt), aggregatedailytran.txttransactions per card, compute totals; parses fixed-width layouts fromapp/cpy/copybooks incl. COBOL signed-overpunch zoned decimals (e.g.0000009190}→-919.00). Run:cd carddemo-java && mvn compile exec:java→ writes onestatement-<accountId>.jsonper account intocarddemo-java/output/statements/(50 statements / 300 transactions fromapp/data/ASCII/).com.carddemo.statement.viewer) — Spring Boot + Thymeleaf:/lists statements,/statements/{accountId}renders name, address, masked card, transaction table and total; alsoGET /api/statements[/{accountId}]. Readscarddemo.statements.dir(defaultoutput/statements/); Jackson fails on unknown properties so contract drift surfaces immediately. Mock fixtures used during parallel development were removed; tests use fixtures undersrc/test/resources/statement-fixtures/.Verification:
(cd carddemo-java && mvn test)— 13 tests pass;(cd carddemo-java && mvn package -DskipTests)passes; viewer verified in-browser against real generated statements.Ticket vs COBOL discrepancy (ticket wins, per instructions)
5000-CREATE-STATEMENTalso emits customer middle name, current balance (ACCT-CURR-BAL) and FICO score (CUST-FICO-CREDIT-SCORE), and 3 combined address lines. The DJ-69 contract intentionally omits middle name, current balance, and FICO score, so the JSON and viewer do too.Before — COBOL-generated HTML statement layout
The COBOL batch cannot execute off-mainframe (CBSTM03A dereferences TIOT/PSA pointers; GnuCOBOL run segfaults), so the BEFORE capture reproduces the exact HTML structure emitted by
5100-WRITE-HTML-HEADER/5200-WRITE-HTML-NMADBS/6000-WRITE-TRANS, populated with the realapp/data/ASCII/sample data.After — new web statement viewer (real generated data)
Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/ceef61b01e144b39ad60fd42e2b198d7
Requested by: @HJscarr