Skip to content

DJ-97: Restyle CBSTM03A HTML statement to professional bank palette - #236

Open
devin-ai-integration[bot] wants to merge 1 commit into
migration/in-progressfrom
DJ-97/restyle-cbstm03a-html-statement
Open

devin-ai-integration[bot] wants to merge 1 commit into
migration/in-progressfrom
DJ-97/restyle-cbstm03a-html-statement

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

Fixes DJ-97: replaces the neon placeholder colours in the HTML-LINES 88-level VALUE literals of app/cbl/CBSTM03A.CBL with a professional bank palette. Literal-only change — no logic/paragraph changes.

Palette mapping:

  • Top banner (HTML-L10): invalid #1d1d96b3 → dark navy #0B2447 + white text
  • "Bank of XYZ" address block (HTML-L15): #FFAF33 → light grey #F2F2F2
  • Section bars (HTML-L30-42): #33FFD1 → light grey #E9ECEF
  • Column-header cells (HTML-L47/L50/L53): #33FF5E → mid-navy #1F4E79, with white bold header text on HTML-L48/L51/L54
  • Consistent cell padding 4px 8px across all styled cells (incl. HTML-L22-35, data cells L58/L61/L64)
  • Column widths (25%/55%/20%) and right-aligned Amount column unchanged; all hex now valid 6-digit

Verification

  • Syntax check passes: cobc -I app/cpy/ --std=ibm-strict -ftab-width=4 -fsyntax-only app/cbl/CBSTM03A.CBL
    • Note: the exact ticket command (without -ftab-width=4) fails on the unmodified baseline too, because app/cpy/CUSTREC.cpy contains tab characters that push fixed-format lines past column 72 with GnuCOBOL 3.1.2's default tab width of 8. Pre-existing, unrelated to this change; -ftab-width=4 makes it pass both before and after.
  • Compiled and ran CBSTM03A/CBSTM03B locally with GnuCOBOL against app/data/ASCII/ (indexed files loaded per CREASTMT.JCL STEP010 sort/OUTREC layout); run completes rc=0 and produces valid HTML statements for all 50 cards.
  • Plain-text STMTFILE output is byte-identical before vs after (cmp clean).

Screenshots

Before:
before

After:
after

Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/064ef2d43eae4aeb8124ba96c72f047b

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants