fix: declare zod as a runtime dependency - #38
Open
mharnett wants to merge 1 commit into
Open
Conversation
zod is imported in src (src/tools/{card,additional,dashboard,table,database}-tools.ts
all `import { z } from "zod"`) but is not listed in any dependency bucket of
package.json. It currently resolves only transitively (e.g. via fastmcp), so a
fresh end-user install could fail to resolve zod if that transitive path
changes. Declare it explicitly in dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
zodis imported in five source files but is not declared inpackage.json:It's absent from
dependencies,devDependencies, andpeerDependencies, so it currently only resolves transitively (e.g. viafastmcp). If that transitive path ever drops or moveszod, a freshnpm installof@cognitionai/metabase-mcp-serverwould fail to resolve it at runtime.Fix
Declare
zodexplicitly independencies(^3.25.76, matching the major already used transitively). One line; no code changes.Devin Review