Skip to content

fix: remove invalid glob from optionalPlugins; fix stale README links - #1

Merged
morgante merged 1 commit into
mainfrom
devin/1785123255-fix-reorg
Jul 27, 2026
Merged

fix: remove invalid glob from optionalPlugins; fix stale README links#1
morgante merged 1 commit into
mainfrom
devin/1785123255-fix-reorg

Conversation

@charliemeyer2000

@charliemeyer2000 charliemeyer2000 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-ups to the root-meta-plugin reorg (c54cabf / 4e763ea):

  • "CognitionAI/**" in optionalPlugins is invalid and breaks the whole plugin. requiredPlugins/optionalPlugins entries are exact source refs — the runtime's spec parsing rejects any wildcard (manifest.rs: "spec parsing reuses source parsing, which rejects any wildcard, so no entry here can be a glob"), so the root manifest fails to parse and the meta-plugin is skipped at load with a warning, taking the entire baseline with it. Globs are only legal in forbiddenPlugins. Removed the entry.
  • README: usacognition/plugin-templateCognitionAI/plugin-template (repo moved), and dropped the link to docs/governance.md (deleted in 4e763ea).

node scripts/validate-template.mjs passes.

Requested by: @charliemeyer2000


Devin Review

Status Commit
🟢 Reviewed a4ca0a7
Open in Devin Review (Staging)

Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
@staging-devin-ai-integration

Copy link
Copy Markdown
Original prompt from charlie.meyer

SYSTEM:
=== BEGIN THREAD HISTORY (in #cmeyer-internal) ===
<most_recent_message>
Charlie Meyer (U0AS1R4CM5M) [ts=1785099102.637089]: @Devin help me build enablement materials for plugins. look at notion and C3: Git Plugin marketplace to undersatand what's going on, then help me underastand the state of how plugins work on cloud and local, what morgante is asking for, and then a plan to build this --action-model claude-fable-5-max

Let me search for those threads now.

Those results don't match what you're looking for. Let me search more specifically for mortgante (likely Marco Morgante or similar) talking about enablement materials for plugins with a GitHub repo example.

Got it — that's Morgante Pell. Let me search for his messages about enablement materials and plugins with a GitHub repo example.

Found one — now let me look for the second thread. The first one is from
<#C0B15442C4E>
(eng-plugins-rollout). Let me search for another message from Morgante about enablement/plugins with a usacognition repo example.

I'm clearly finding the same one thread. The second one may involve a
usacognition example repo specifically — let me check if there's another thread where Morgante shared one of those repos.

Let me check the thread on that first message and also look for the second thread — it may have been a reply in a thread rather than a top-level message, or it could be in a different channel.

I found one thread clearly. Now let me look more broadly — the second thread may involve a
usacognition example repo that Morgante shared, possibly in a different channel or as a reply.

I can see a reference in the search results to a second thread — Morgante's "Quick QA on plugins" thread from July 23 against &lt;http://github.com/COG-GTM/plugins-marketplace|github.com/COG-GTM/plugins-marketplace&gt;. Let me find that one.

Found both threads. Here they are:

Thread 1 — Tagging you for enablement materials ownership <https://cognition.enterprise.slack.com/arch... (2957 chars truncated...)

@staging-devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration staging-devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review (Staging)
Debug

Playground

Comment thread .devin-plugin/plugin.json
Comment on lines 36 to +37
"path": "plugins/frontend-design"
},
"CognitionAI/**"
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Validator does not catch wildcard entries in required/optionalPlugins

The root cause of this PR (a glob string inside optionalPlugins) would not be caught by scripts/validate-template.mjs: the loop only walks plugins/*/.devin-plugin/plugin.json and never validates the root .devin-plugin/plugin.json, and the same-repo reference check at scripts/validate-template.mjs:95-112 skips non-object entries entirely. Adding a check that rejects string/glob entries in requiredPlugins/optionalPlugins and that includes the root manifest would prevent a regression of this exact failure, which silently disables the whole meta-plugin at load time.

Open in Devin Review (Staging)

Was this helpful? React with 👍 or 👎 to provide feedback.

Debug

Playground

@morgante
morgante merged commit 2169376 into main Jul 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants