fix: remove invalid glob from optionalPlugins; fix stale README links - #1
Conversation
Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
Original prompt from charlie.meyer
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
| "path": "plugins/frontend-design" | ||
| }, | ||
| "CognitionAI/**" | ||
| } |
There was a problem hiding this comment.
🔍 Validator does not catch wildcard entries in required/optionalPlugins
The root cause of this PR (a glob string inside optionalPlugins) would not be caught by scripts/validate-template.mjs: the loop only walks plugins/*/.devin-plugin/plugin.json and never validates the root .devin-plugin/plugin.json, and the same-repo reference check at scripts/validate-template.mjs:95-112 skips non-object entries entirely. Adding a check that rejects string/glob entries in requiredPlugins/optionalPlugins and that includes the root manifest would prevent a regression of this exact failure, which silently disables the whole meta-plugin at load time.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Follow-ups to the root-meta-plugin reorg (c54cabf / 4e763ea):
"CognitionAI/**"inoptionalPluginsis invalid and breaks the whole plugin.requiredPlugins/optionalPluginsentries are exact source refs — the runtime's spec parsing rejects any wildcard (manifest.rs: "spec parsing reuses source parsing, which rejects any wildcard, so no entry here can be a glob"), so the root manifest fails to parse and the meta-plugin is skipped at load with a warning, taking the entire baseline with it. Globs are only legal inforbiddenPlugins. Removed the entry.usacognition/plugin-template→CognitionAI/plugin-template(repo moved), and dropped the link todocs/governance.md(deleted in 4e763ea).node scripts/validate-template.mjspasses.Requested by: @charliemeyer2000
Devin Review
a4ca0a7