Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/control-plane/src/session/durable-object.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1316,10 +1316,10 @@ export class SessionDO extends DurableObject<Env> {
}

/**
* Broadcast message to all connected clients.
* Broadcast message to all authenticated clients.
*/
private broadcast(message: ServerMessage): void {
this.wsManager.forEachClientSocket("all_clients", (ws) => {
this.wsManager.forEachClientSocket("authenticated_only", (ws) => {
this.wsManager.send(ws, message);
});
}
Expand Down
39 changes: 39 additions & 0 deletions packages/control-plane/src/session/websocket-manager.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,45 @@ describe("SessionWebSocketManagerImpl", () => {
expect(called).toHaveLength(0);
});

it("broadcast pattern delivers to authenticated clients and skips unauthenticated", () => {
const { manager, sockets, mockRepo } = createManager();

// Authenticated client (in-memory)
const authedWs = createFakeWebSocket();
sockets.set(authedWs, ["wsid:ws-authed"]);
manager.setClient(authedWs, createClientInfo({ ws: authedWs }));

// Post-hibernation client (persisted mapping only, no in-memory ClientInfo)
const hibernatedWs = createFakeWebSocket();
sockets.set(hibernatedWs, ["wsid:ws-hibernated"]);
mockRepo.addMapping("ws-hibernated", {
participant_id: "p-2",
client_id: "c-2",
user_id: "u-2",
github_name: null,
github_login: null,
});

// Unauthenticated client (connected but never subscribed)
const unauthWs = createFakeWebSocket();
sockets.set(unauthWs, ["wsid:ws-unauth"]);

// Sandbox (should never receive)
const sandboxWs = createFakeWebSocket();
sockets.set(sandboxWs, ["sandbox", "sid:sb-1"]);

// Simulate the DO's broadcast() pattern
const message = JSON.stringify({ type: "sandbox_status", status: "ready" });
manager.forEachClientSocket("authenticated_only", (ws) => {
manager.send(ws, message);
});

expect(authedWs.send).toHaveBeenCalledWith(message);
expect(hibernatedWs.send).toHaveBeenCalledWith(message);
expect(unauthWs.send).not.toHaveBeenCalled();
expect(sandboxWs.send).not.toHaveBeenCalled();
});

it("never calls fn for sandbox sockets regardless of mode", () => {
const { manager, sockets } = createManager();
const sandboxWs = createFakeWebSocket();
Expand Down
Loading