Private/minion/push myxoyprylvvm #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a change I've been hoping to make for a while... hopefully this should make the tangle of everything a bit more readable I'm also expecting to add some more various similar shells - so this should help with the problem of the ever-growing nilla.nix *and* maybe make it more likely that we do some inheriting/etc. rather than reinventing the shell wheel a hundred times... There's various more stuff to upstream here before we're up-to-date with what's needed for recent CollaboraOnline/online, but this is a good first bit to make later work easier
bear makes a compilation database from running a command, which is required for some language servers. Core has a different way of generating these which doesn't need you to run bear directly, but online does
Minion3665
force-pushed
the
private/minion/push-myxoyprylvvm
branch
from
7528502 to
c1c3887
Compare
chromium is needed for running cypress tests properly. We previously had this in the android-online shell, but we need it in online too. As android-online inherits packages from online, we don't need to specify it in both
We don't need anything like the overhead we started off with... let's clean it up as simpler flags often lead to less surprising breakages
android-studio is downloading/symlinking things - and quite a lot of things - so in my testing it takes *way* longer to do this remotely...
We're interested in using Kotlin to write future Android code, e.g. some tests, so let's install it in the relevant shell!
The core build now fails without this; let's add it
The typescript language server isn't enough to get coverage of every online file; it's worth installing the whole vscode language server pack
Minion3665
force-pushed
the
private/minion/push-myxoyprylvvm
branch
from
c1c3887 to
f9d30f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.