docs: describe what the shell variables are for #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minion3665
force-pushed
the
private/minion/push-mxmzmstokkvq
branch
from
ad79bea to
b41c621
Compare
I've had feedback that the variables are confusing as you may be expecting to replace them if you've seen other install guides/etc. in the past. Let's be clear about what they are to avoid confusion
Minion3665
force-pushed
the
private/minion/push-mxmzmstokkvq
branch
from
b41c621 to
81fcab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had feedback that the variables are confusing as you may be expecting to replace them if you've seen other install guides/etc. in the past. Let's be clear about what they are to avoid confusion