Revert "cypress: skip failing linespacing test" #11642
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
force-pushed
the
private/eszkadev/cypress-restore-linespacing
branch
from
814a87d to
c967bd4
Compare
eszkadev
force-pushed
the
private/eszkadev/cypress-restore-linespacing
branch
from
c967bd4 to
a510bb2
Compare
Contributor
Author
|
still fails |
eszkadev
force-pushed
the
private/eszkadev/cypress-restore-linespacing
branch
from
a510bb2 to
77db286
Compare
This reverts commit 4a4c09e. Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I9ca7b8adc0060c03d359bfa2cdc96538c7ad5e5e
eszkadev
force-pushed
the
private/eszkadev/cypress-restore-linespacing
branch
from
77db286 to
54db5dc
Compare
Contributor
Author
|
testing after https://gerrit.libreoffice.org/c/core/+/185196 was merged |
Contributor
This still fails. I think the reason is that the cypress test asserts spacing of text in Impress, while my fix was just around bullet characters for lists in Writer, so the two are not connected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4a4c09e.