Private/gokay/aspect ratio #13892
Private/gokay/aspect ratio #13892
Conversation
timar
force-pushed
the
private/gokay/aspect-ratio
branch
from
f0394c7 to
2e69e92
Compare
gokaysatir
force-pushed
the
private/gokay/aspect-ratio
branch
from
2e69e92 to
e5bb5cb
Compare
Kooha-2025-12-23-13-48-10.webmI can reproduce with this patch. One issue is also: when I resize so image goes outside "page" - it makes weird flip and aspect ratio change |
gokaysatir
force-pushed
the
private/gokay/aspect-ratio
branch
from
e5bb5cb to
2606873
Compare
Thanks for checking. I changed how we approach to the issue. This is more aligned with the core side behaviour. |
gokaysatir
force-pushed
the
private/gokay/aspect-ratio
branch
from
2606873 to
ab6b07e
Compare
thanks, now it seems to respect aspect ratio. But let's fix the "flip" issue later as you say |
| return [rectangle.x1, rectangle.center[1]]; | ||
| else if (handleID === '4') | ||
| return [rectangle.x2, rectangle.center[1]]; | ||
| else if (handleID === '5') |
There was a problem hiding this comment.
we should have enum for these numbers
cypress_test/integration_tests/desktop/writer/image_operation_spec.js
Outdated
Show resolved
Hide resolved
eszkadev
force-pushed
the
private/gokay/aspect-ratio
branch
from
ab6b07e to
4c90cfc
Compare
|
|
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ib432c5c1c616d72b174fe725145e0c0dc9521890
…ue to snapping points. Changes:There are 3 things here: * Use the same properties with the preview so it is easier to manage. Cancel snapping while scaling. * Don't keep ratio if the user is scaling using the edge points but not the corners. Core side also works this way. * Checked the crop in Writer and modified the test accordingly. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Icdebaa163d1cb03fe44fc8e243e620990b43c09c
* Pick right crop handle instead of the left to ensure it doesn't overlap with other UI elements. * Visually / manually check the test to ensure it checks the correct results. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I917897a788ca62812f01483ac70869d895b28c92
gokaysatir
force-pushed
the
private/gokay/aspect-ratio
branch
from
4c90cfc to
1cd551b
Compare
cypress_test/integration_tests/desktop/calc/image_operation_spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I541c5fe8103c69662995d0f5bf41b4f135b952ae
|
I added cypress test fix. BEFORE: AFTER: |
|
:) Thanks for checking @eszkadev . I checked it again. It is interesting because we are not changing the height there. I checked it again now. Please see video below. It is how it seems on my machine. I am not sure where the difference comes from. 1.mp4 |
|
In the video, test suite quickly widens the image and then checks its size. |
Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I8b178b50819c1df8c0ea362a1307c28b69a10083
exactly what happened before my fix :) Did you pull ? Kooha-2026-01-05-14-08-58.webm |
|
I adjusted the same way writer test, now we have in Calc Y move and in Writer X move so we test both |
Okay, then thank you for the additions. |
2 participants
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay