CODA-Q: A better way to find data files #13893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on
https://build.opensuse.org/projects/home:fstrba/packages/collaboraoffice-desktop/files/0001-Standalone-coda-qt.patch by Fridrich Štrba [email protected].
For one, finding the data files should either
for a scenario where a developer runs the built qt/coda-qt directly from the source tree: use the data files from the source tree (though this will still not support out-of-tree builds); or
for a scenario where a coda-qt installed into the system (via
make install) is run: use the data files installed into the system (i.e., COOLWSD_DATADIR).And for another, finding the LICENSE.html in the separate collaboraoffice installation should go via LO_PATH, instead of via some relative path.
Change-Id: Ifd01d46229cd90f68f3d6eacb47cd751a08d7310
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay