Skip to content

Conversation

@stbergmann
Copy link
Contributor

This is based on
https://build.opensuse.org/projects/home:fstrba/packages/collaboraoffice-desktop/files/0001-Standalone-coda-qt.patch by Fridrich Štrba [email protected].

For one, finding the data files should either

  • for a scenario where a developer runs the built qt/coda-qt directly from the source tree: use the data files from the source tree (though this will still not support out-of-tree builds); or

  • for a scenario where a coda-qt installed into the system (via make install) is run: use the data files installed into the system (i.e., COOLWSD_DATADIR).

And for another, finding the LICENSE.html in the separate collaboraoffice installation should go via LO_PATH, instead of via some relative path.

Change-Id: Ifd01d46229cd90f68f3d6eacb47cd751a08d7310

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

This is based on
<https://build.opensuse.org/projects/home:fstrba/packages/collaboraoffice-desktop/files/0001-Standalone-coda-qt.patch>
by Fridrich Štrba <[email protected]>.

For one, finding the data files should either

* for a scenario where a developer runs the built qt/coda-qt directly from the
  source tree: use the data files from the source tree (though this will still
  not support out-of-tree builds); or

* for a scenario where a coda-qt installed into the system (via `make install`)
  is run: use the data files installed into the system (i.e., COOLWSD_DATADIR).

And for another, finding the LICENSE.html in the separate collaboraoffice
installation should go via LO_PATH, instead of via some relative path.

Signed-off-by: Stephan Bergmann <[email protected]>
Change-Id: Ifd01d46229cd90f68f3d6eacb47cd751a08d7310
@stbergmann
Copy link
Contributor Author

@fridrich, @Quwex, @timar: Any thoughts? Maybe we could find something even better that would even work for a developer's out-of-tree build?

@stbergmann stbergmann removed the draft label Dec 19, 2025
@fridrich
Copy link

@fridrich, @Quwex, @timar: Any thoughts? Maybe we could find something even better that would even work for a developer's out-of-tree build?

The out of tree builds could be supported if we made the flag file run-from-build.in and then configure could generate the run-from-build at the configure time. That would put the file into the same place as the built coda-qt, I guess.

Signed-off-by: Fridrich Štrba <[email protected]>
Change-Id: Ifc050bff24ada2bd9b70997d11156e4fd23b5b19
Signed-off-by: Fridrich Štrba <[email protected]>
Change-Id: Id10d1a8584115b442a55399264524eaf8d66e5ad
@stbergmann stbergmann merged commit 5262210 into distro/collabora/coda-25.04 Jan 6, 2026
3 checks passed
@stbergmann stbergmann deleted the private/sberg/20251219-1 branch January 6, 2026 09:43
@github-project-automation github-project-automation bot moved this from To Review to Done in Collabora Online Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants