fix navigator comments being scrolled off #13953
Conversation
Signed-off-by: Sahil Gautam <[email protected]> Change-Id: If74cc69f9efc6a9c7fe4765b4d5a61cc71b8b118
[1] reduced the navigator sidebar width from 330px to 250px, but it
didn't take into account the overflow-x (which is hidden). when the
elements were inserted dynamically (by javascript), they got scrolled
off to the left side giving an impression that they are cut off.
this patch increases the width to 266px as at that width, no overflow-x
exists on navigator-dock-wrapper.
also change the impress/statusbar_spec as with the new increased width,
the zoom is not 70% but 60% at the test's window size.
--
[1] Reduce the navigator sidebar width and change bg color for navigator
85d604d
Signed-off-by: Sahil Gautam <[email protected]>
Change-Id: Iaf769bdce11dc27fa11af3f831f691bc2d6c9cad
printfdebugging
force-pushed
the
private/printfdebugging/navigator-comments-cut-off
branch
from
646f0cd to
6eea389
Compare
|
what does that fix? how to test? |
| */ | ||
| #navigation-sidebar { | ||
| width: 250px; | ||
| width: 266px; |
There was a problem hiding this comment.
Unfortunately, adjusting the width doesn't fix the problem, as it seems to be a position problem.
There was a problem hiding this comment.
@eszkadev for how to test
- open a document with comments
- click on the three dots on the comment (to show the comment menu) and click on "Show in Navigator"
- see the navigator.
The comments were scrolled off to the left before this patch (because there's a hidden element which is wider than 250px).
There was a problem hiding this comment.
I see , even with English I see the same result
There was a problem hiding this comment.
So do I consider this approved or do we need some changes here? Because my investigations suggested it's a width issue (the width of navigator being smaller than the widest element in it (which is hidden) leading to overflow and hence cut-off. If you inspect the navigator-doc-wrapper element, you will find that it has overflow-x hidden, unchecking that css property shows the problem
3 participants
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay