Skip to content

convert listbox widget to typescript #13955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eszkadev merged 5 commits into from
Jan 6, 2026
Merged

convert listbox widget to typescript #13955

eszkadev merged 5 commits into from
Jan 6, 2026

Conversation

@printfdebugging
Copy link
Contributor

@printfdebugging printfdebugging commented Jan 4, 2026

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@github-project-automation github-project-automation bot moved this to To Review in Collabora Online Jan 4, 2026
eszkadev
eszkadev reviewed Jan 5, 2026
View reviewed changes
eszkadev
eszkadev reviewed Jan 5, 2026
View reviewed changes
eszkadev
eszkadev reviewed Jan 5, 2026
View reviewed changes
@eszkadev
Copy link
Contributor

eszkadev commented Jan 5, 2026

prettier:

make[1]: Entering directory '/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-25.04/browser'
  PRETTIER prettier
  ESLINT   eslint
[warn] src/control/jsdialog/Widget.Listbox.ts
[warn] Code style issues found in the above file. Run Prettier with --write to fix.

@printfdebugging
move listboxControl code from JSDialogBuilder.js to it's own js file
cf1f4be 
Signed-off-by: Sahil Gautam <[email protected]>
Change-Id: If0a6e315de5ef0cab2e6d4d686e34ebcce7285c5
@printfdebugging
create variables for long conditions
2ea9fc0 
Signed-off-by: Sahil Gautam <[email protected]>
Change-Id: I1afaee6ab6a36e3e7fec40a83fed2a1da8b10ed2
@printfdebugging
use const and let instead of var
f8e1973 
Signed-off-by: Sahil Gautam <[email protected]>
Change-Id: Ibecee6fc256fd6f4a6ed281d8032acbd1bac0777
@printfdebugging
convert Widget.Listbox.js to typescript
a9f58ba 
Signed-off-by: Sahil Gautam <[email protected]>
Change-Id: I4e10154059b64661bf4ce3cce0de495ce7e8b572
@printfdebugging
formatting changes
f7c44ea 
Signed-off-by: Sahil Gautam <[email protected]>
Change-Id: If0b757cff57aa86a76e1917a69ae2d871c816dc0
@printfdebugging printfdebugging force-pushed the private/printfdebugging/listbox branch from 8f06a30 to f7c44ea Compare January 5, 2026 14:10
@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Jan 6, 2026
@eszkadev eszkadev merged commit c35f0bc into main Jan 6, 2026
15 checks passed
@eszkadev eszkadev deleted the private/printfdebugging/listbox branch January 6, 2026 06:34
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eszkadev eszkadev eszkadev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Collabora Online
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@printfdebugging @eszkadev