Skip to content

Conversation

@Darshan-upadhyay1110
Copy link
Contributor

  • change id of prev and next page option for better readability

Change-Id: I962a4b4f745d53e8b6e002e7d57edd83dd8bd303

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Jan 5, 2026
@eszkadev eszkadev enabled auto-merge (rebase) January 5, 2026 09:12
@eszkadev
Copy link
Contributor

eszkadev commented Jan 5, 2026

some test code uses old id:
AssertionError: Timed out retrying after 10000ms: Expected to find element:#toolbar-down #next, but never found it. Queried from:

@Darshan-upadhyay1110 Darshan-upadhyay1110 force-pushed the private/darshan/change-id-of-page-change-icon branch from 86ed0cf to a251497 Compare January 5, 2026 10:28
- change id of prev and next page option for better readability

Signed-off-by: Darshan-upadhyay1110 <[email protected]>
Change-Id: I962a4b4f745d53e8b6e002e7d57edd83dd8bd303
@Darshan-upadhyay1110 Darshan-upadhyay1110 force-pushed the private/darshan/change-id-of-page-change-icon branch from a6aae54 to 8f1318b Compare January 6, 2026 07:05
@eszkadev
Copy link
Contributor

eszkadev commented Jan 6, 2026

  1) Comment Scrolling
       switch to previous or next slide:
     AssertionError: Timed out retrying after 10000ms: Expected to find element: `#prev-button`, but never found it. Queried from:

              > cy.get(#coolframe, [object Object]).its(0.contentDocument, [object Object])
      at Context.eval (webpack://cypress_test/./support/index.js:174:0)


  │ Duration:     1 minute, 21 seconds                                                             │
  │ Spec Ran:     impress/annotation_spec.js    

- updated the prev and next icon id in cypress files
- this will be now consistent with the id we change in our last commit

Signed-off-by: Darshan-upadhyay1110 <[email protected]>
Change-Id: I1c6418536d94e5b4968d94fb4af12d4edc2b1b20
@Darshan-upadhyay1110 Darshan-upadhyay1110 force-pushed the private/darshan/change-id-of-page-change-icon branch from 8f1318b to de867f8 Compare January 6, 2026 18:19
@eszkadev eszkadev merged commit 2ad94c4 into main Jan 6, 2026
15 checks passed
@eszkadev eszkadev deleted the private/darshan/change-id-of-page-change-icon branch January 6, 2026 19:23
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants