Backport-13944 #13968
Merged
Backport-13944 #13968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Before this patch keybindings were not working on start slide show presentation - we do added event listener with capture phase so the `keydown` will not get override by other key binding - start window needs to have the the top priority for arrow key listeners This fixes an issue in Firefox where arrow keys would not reliably trigger slide changes when presenting in window mode. Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I604c1df0ace918d4bda4877390e92837b9b058d9
eszkadev
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #13944
keydownwill not get override by other key bindingThis fixes an issue in Firefox where arrow keys would not reliably trigger slide changes when presenting in window mode.
Change-Id: I604c1df0ace918d4bda4877390e92837b9b058d9
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay