Private/caolan/morea11ytraverse #13970
Merged
+53
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolan/morea11ytraverse
branch
4 times, most recently
from
74b500b to
ae02232
Compare
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ie3f8367755e84df954902a6bae8dcc0ceb077e28
caolanm
force-pushed
the
private/caolan/morea11ytraverse
branch
3 times, most recently
from
7491eac to
c5f02d3
Compare
schedule retry if there are other tasks, but limit to some arbitrary value of retries before happening anyway to ensure this gets called. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ibfd66365ea2d8fa7c7ba9a4f50d0019f0d09ac33
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I2563e2975152e83a7dc823bdd63b309a8a6f1867
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ie5ab0ca30c7df298065681231af6661c5ab6c6f1
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I85e912f35d53d0fc41c13d3184e7f6160080adca
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I97621a66ba87e199bca47137183e5f0c74614c78
caolanm
force-pushed
the
private/caolan/morea11ytraverse
branch
from
c5f02d3 to
6353247
Compare
Contributor
Author
|
The main bits are trying to make things more reliable by:
|
eszkadev
reviewed
Jan 9, 2026
| .should('have.length.at.least', level) | ||
| .last(); | ||
| .should('have.length', level) | ||
| .then($dialogs => cy.wrap($dialogs.last())) |
Contributor
There was a problem hiding this comment.
what's the difference here .then(...) vs .last()?
I stopped to use then for getters if there is no reason behind (we were failing on that in the past).
It's meant to be used for one-time "actions" (no auto-retry is provided).
https://docs.cypress.io/api/commands/should#Differences
eszkadev
approved these changes
Jan 9, 2026
Contributor
|
good to see the 5 levels of callbacks squashed into onDrain! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay