CODA-Q: Cleanup DBus name registration when exiting.

[jpwhiting]

Added a desctructor to DBusService that unregisters the object and service during shutdown.
This should fix any issues users may be having with the flatpak leaving the name in use after exit causing the application to not launch afterwards.

I think this is an improvement, but I'm not 100% sure how to test what I built. flatpak list shows a test branch version, but I'm not sure if that's what I just built locally with my changes or something else. Anyway, wanted to get more eyes on it in case this is all we need. Will continue to figure out if what I'm testing is what I built.

Change-Id: I6af3a852433d28ccc6fe3b4ebb3b9a0f6a39a579

• Resolves: #
• Target version: main

Summary

TODO

• ...

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[Quwex]

@jpwhiting Is this about a specific report? Would be nice to know if there's a way to reproduce the problem. My assumption at least was either the DBus daemon automatically releases service names when the connection closes or Qt was already handling unregistering appropriate bits on QCoreApplication destructor when QDBusConnection closes.

[jpwhiting]

@jpwhiting Is this about a specific report? Would be nice to know if there's a way to reproduce the problem. My assumption at least was either the DBus daemon automatically releases service names when the connection closes or Qt was already handling unregistering appropriate bits on QCoreApplication destructor when QDBusConnection closes.

I looked at the board and couldn't find anything there. @thorstenb mentioned it in a call we had the day before I left for holidays. I didn't have time to look into it then, but took a stab at it yesterday. I think in some cases the dbus server unregisters things as needed, but at least here I had to hit ctrl-c after closing all windows to get back to a prompt when running the flatpak. With these changes it exited properly though maybe I wasn't testing what I thought I was. I'm not as familiar with flatpak as I'd like to be.