Don't use an identifier starting with an underscore and an uppercase … #13975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letter Such are reserved for the C++ implementation. It's typical. A day after me complaining about the bad habit of using initial underscores in https://gerrit.libreoffice.org/c/core/+/196572 , I notice that I did it myself just a week or so earlier here, in the freshly written RecentFiles class. Here in online the convention to use an initial underscore for private class members comes from Poco. Ideally we should get rid of all of it. But that will take time. Until then at least we shouldn't use identifiers starting with an undersore and an uppercase letter. Such are definitely reserved. (Identifiers starting with a single underscore and a lowercase letter are apparently OK, but as it is easy to forget exactly what is reserved, IMNSHO it is best to avoid them, too.) Signed-off-by: Tor Lillqvist <[email protected]> Change-Id: I645eef09b5b44d8301b98b0d537d1061875b950f
codewithvk
deleted the
private/tml/I645eef09b5b44d8301b98b0d537d1061875b950f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…letter
Such are reserved for the C++ implementation.
It's typical. A day after me complaining about the bad habit of using initial underscores in https://gerrit.libreoffice.org/c/core/+/196572 , I notice that I did it myself just a week or so earlier here, in the freshly written RecentFiles class.
Here in online the convention to use an initial underscore for private class members comes from Poco. Ideally we should get rid of all of it. But that will take time. Until then at least we shouldn't use identifiers starting with an undersore and an uppercase letter. Such are definitely reserved. (Identifiers starting with a single underscore and a lowercase letter are apparently OK, but as it is easy to forget exactly what is reserved, IMNSHO it is best to avoid them, too.)
Change-Id: I645eef09b5b44d8301b98b0d537d1061875b950f
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay