Skip to content

Conversation

@eszkadev
Copy link
Contributor

@eszkadev eszkadev commented Jan 6, 2026

  • missing icons
  • missing css rules for some buttons
  • missing id

dialog to test: Writer -> Format -> Heading

backports of:
#13864
#13908
#13936

- writer -> style sidebar -> new by example button
- it was getting blurry bitmap, replace with svg

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: Ib8390153e4fb18bd0f93595c963b630338933650
- it is needed for a styles sidebar in writer
  to hide unwanted items from a toolbox

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: Id984af10d9c9b481aa692e8ae097c9572f577a42
- we were missing symbol button images
- it was hidden because of that
- height was 0 too

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I58b79f63313b3c3a5a510185f971fe370559e5e0
- dialog content buttons can have any width they need
- dialog action buttons (ok, cancel...) should have
  equal minimal width to look similar
- fixes regression from commit 56c24b5
  css: revert complex custom button sizing
- in Calc -> Formula Wizard -> field buttons in the right box should
  not be too big to not force horizontal scrollbar
- helps with passing cypress visual test in
  desktop/calc/formula_dialog_spec.js

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: Ib0e0f56806a8a52622b5cd08401fc6a125087961
- menubuttons with text should be wide enough to present
  that text
- can be seen in Writer -> Format -> Heading Numbering dialog

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I50bb64c20fca98f09d9f472c05b3d488a1d607f7
Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I1b78a06bbeb004041389692a66823784cdb87814
@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Jan 6, 2026
@Darshan-upadhyay1110
Copy link
Contributor

Hii @eszkadev I see some mismatch in your backport commits

#13900 this PR commit is missing in backport

Also the last commit eb57f69

there is no PR in description matches with the last commit

@eszkadev
Copy link
Contributor Author

eszkadev commented Jan 7, 2026

Hii @eszkadev I see some mismatch in your backport commits

I see I took wrong one. But it's fine ->

#13900 this PR commit is missing in backport

I will add that.

Also the last commit eb57f69

This commit makes preparation for adding more TS types, we were missing mandatory id in menu definitions. No functional change.
It's part of: #13908 which I don't backport fully as it's TS conversion not a bug fix.

@eszkadev
Copy link
Contributor Author

eszkadev commented Jan 7, 2026

The #13900 is "empty" after applying, what means we didn't backport reverted patch yet - removed form a list. No need to add anything. Thanks for checking :)

@eszkadev eszkadev merged commit 6b4cb88 into distro/collabora/co-25.04 Jan 7, 2026
3 checks passed
@eszkadev eszkadev deleted the private/eszkadev/backport-25-fixes branch January 7, 2026 06:53
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants