security: change team member delete from GET to POST#199
Open
sumnerevans wants to merge 1 commit intomasterfrom
Open
security: change team member delete from GET to POST#199sumnerevans wants to merge 1 commit intomasterfrom
sumnerevans wants to merge 1 commit intomasterfrom
Conversation
Destructive operations must not be triggered via GET — any page with an <img> or prefetch link pointing at the URL could silently delete members for a logged-in teacher. Replaced the <a> link with a <form method=POST> and switched the handler to read params from the form body. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /register/teacher/team/deleteperformed a destructive action (removing a team member)<img src="...">, link prefetch, or browser history replay could trigger deletion for a logged-in teacher<a href>link inteamedit.htmlwith a<form method=POST>emailandteam_idfrom the form body instead of the query stringTest plan
GET /register/teacher/team/deletenow returns 405 Method Not Allowed🤖 Generated with Claude Code