Skip to content

N°8268 - Document SynchroAttribute columns #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 1, 2023

This adds possibility to let data collectors know which column names are available to be synchronised.

Problem:

  • Sometimes the column name is not the same as iTop attribute code
  • Sometimes an attribute has multiple columns (Blob, ...)

See also counterpart PR Combodo/itop-data-collector-base#37.

@Hipska
Copy link
Contributor Author

Hipska commented Jan 23, 2024

Can we have some feedback please?

@Hipska
Copy link
Contributor Author

Hipska commented Jul 10, 2024

Anyone?

@jf-cbd
Copy link
Contributor

jf-cbd commented Dec 13, 2024

Hello @Hipska, thanks for the PR, and sorry for the delay.
Answering here for the current PR and Combodo/itop-data-collector-base#37.
Functionally, your PR is very interesting.
Technically, we'll perform a check and come back to you soon because we have a few concerns about performances (e.g.memory limit used by collector) and interface.

@jf-cbd
Copy link
Contributor

jf-cbd commented Dec 20, 2024

Hello Hipska,
In your PR, what is the expected behavior with the existing data ?

@Hipska
Copy link
Contributor Author

Hipska commented Dec 20, 2024

As you can see, current items aren't updated yet, but I guess that would be needed of course. First question is if @Combodo would accept this addition at all..

@jf-cbd
Copy link
Contributor

jf-cbd commented Dec 20, 2024

If there is no performance issue nor technical problem (we'll continue investigating on that), then yes Combodo is interested in this enhancement :) But we also need to think about what happens with the current data.

@Hipska
Copy link
Contributor Author

Hipska commented Jan 7, 2025

Current data should be updated during setup.

@Hipska
Copy link
Contributor Author

Hipska commented Feb 13, 2025

@jf-cbd Any update? Should I continue to support this?

@jf-cbd jf-cbd changed the title Document SynchroAttribute columns N°8268 - Document SynchroAttribute columns Mar 14, 2025
@jf-cbd jf-cbd moved this from Pending technical review to Pending functional review in Combodo PRs dashboard Apr 1, 2025
@jf-cbd
Copy link
Contributor

jf-cbd commented Apr 24, 2025

Hello @Hipska, when I'm trying to create a Synchro Data Source (for example on a document file), I have the following error :
"The object cannot be saved : Unexpected value for attribute 'Import Columns' (import_columns) : Null not allowed", but I don't have any field to set this attribute. Does it work for with an iTop on your branch ?

@Hipska
Copy link
Contributor Author

Hipska commented Apr 24, 2025

Strange, doesn't the CreateSynchroAtt method get called?

@jf-cbd
Copy link
Contributor

jf-cbd commented Apr 24, 2025

Doesn't look like it

@Hipska
Copy link
Contributor Author

Hipska commented Apr 24, 2025

You're right, it seems the code has many duplicates. Fixed with 9dd25ca by de-duplicating them.

@jf-cbd jf-cbd moved this from Pending functional review to Pending Combodo update in Combodo PRs dashboard Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Pending Combodo update
Development

Successfully merging this pull request may close these issues.

4 participants