N°8148 - CAS problem when sending a link ending in ˒
Merged
rquetiez merged 3 commits intosupport/3.2from Jun 30, 2025
Merged
N°8148 - CAS problem when sending a link ending in ˒rquetiez merged 3 commits intosupport/3.2from
rquetiez merged 3 commits intosupport/3.2from
Conversation
jf-cbd
approved these changes
Jun 5, 2025
- Code review update
Contributor
|
Test comment for VCS integration... |
rquetiez
requested changes
Jun 12, 2025
Contributor
rquetiez
left a comment
rquetiez
left a comment
There was a problem hiding this comment.
A few files could be left unchanged (unless a double ampersand in the middle of a URL could be an issue)
rquetiez
approved these changes
Jun 30, 2025
Contributor
rquetiez
left a comment
rquetiez
left a comment
There was a problem hiding this comment.
Ok for the proposed implementation that enforces a correct format even if the trailer parameter is removed some time in the future...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
https://support.combodo.com/pages/UI.php?operation=details&class=Bug&id=8148&c[menu]=TargetOverview
Symptom (bug) / Objective (enhancement)
Some url in iTop ends with a ampersand, that king of url are not processed by some CAS authentication providers,
so if user create shortcut to that url and trying to access them when they are not currently logged, the authentication process failed.
Reproduction procedure (bug)
Not reproduced with ou CAS server couple to a LDAP server, the url are processed correctly.
Cause (bug)
URL ending with ampersand
Proposed solution (bug and enhancement)
Prevent iTop from generating url ending with ampersand.
Checklist before requesting a review