Skip to content

Feature/8399 portal attachments on stimulus#723

Merged
bdalsass merged 1 commit intosupport/3.2from
feature/8399-portal-attachments-on-stimulus
Jun 6, 2025
Merged

Feature/8399 portal attachments on stimulus#723
bdalsass merged 1 commit intosupport/3.2from
feature/8399-portal-attachments-on-stimulus

Conversation

@bdalsass
Copy link
Contributor

@bdalsass bdalsass commented Jun 4, 2025

Base information

https://support.combodo.com/pages/UI.php?operation=details&class=Bug&id=8399&&login_again=1749042764665

Symptom (bug) / Objective (enhancement)

Portal transition forms show unwanted attachments

Reproduction procedure (bug)

  1. On iTop 3.2.1
  2. Create a request in portal
  3. Resolve it from console
  4. Re-open it on portal

You can see a form with attachment and noting else

Cause (bug)

This feature have been added in iTop 3.2.1.
It'a add attachments if they are handled by class.

Proposed solution (bug and enhancement)

Do not show attachment when we are in a transition form.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

@bdalsass bdalsass added this to the 3.2.2 milestone Jun 4, 2025
@bdalsass bdalsass requested a review from jf-cbd June 4, 2025 14:40
@bdalsass bdalsass self-assigned this Jun 4, 2025
@bdalsass bdalsass added core internal Work made by Combodo labels Jun 4, 2025
@bdalsass bdalsass changed the base branch from develop to support/3.2 June 4, 2025 14:41
@bdalsass bdalsass merged commit 2e77713 into support/3.2 Jun 6, 2025
1 of 2 checks passed
@bdalsass bdalsass deleted the feature/8399-portal-attachments-on-stimulus branch June 6, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants