N°7289 - Read-only attribute, dynamically read-write, entry silently ignored on submission

[accognet]

use this delta with GetCurrentValue in place of Get and Vincent's example (in bug 7289) will work :

<?xml version="1.0" encoding="UTF-8"?>
<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.1">
  <classes>
    <class id="Location" _created_in="itop-structure" _delta="must_exist">
      <fields>
        <field id="person_id" xsi:type="AttributeExternalKey" _delta="define">
          <sql>person_id</sql>
          <filter/>
          <dependencies>
            <attribute id="status"/>
          </dependencies>
          <is_null_allowed>true</is_null_allowed>
          <target_class>Person</target_class>
          <on_target_delete>DEL_AUTO</on_target_delete>
          <tracking_level>all</tracking_level>
        </field>
      </fields>
      <methods>
        <method id="GetAttributeFlags" _delta="define">
          <comment></comment>
          <static>false</static>
          <access>public</access>
          <code><![CDATA[public function GetAttributeFlags($sAttCode, &$aReasons = array(), $sTargetState = '')
{
	if (($sAttCode == 'person_id') && ($this->GetCurrentValue('status') == 'inactive'))
    {
       // Combine the new Flag with those impose by a parent class
       return(OPT_ATT_READONLY | parent::GetAttributeFlags($sAttCode, $aReasons, $sTargetState));
    }
    return parent::GetAttributeFlags($sAttCode, $aReasons, $sTargetState);
	}]]></code>
        </method>
      </methods>
      <presentation>
        <details >
          <items>
            <item id="person_id" _delta="define">
              <rank>100</rank>
            </item>
          </items>
        </details>
      </presentation>
    </class>
  </classes>
  <dictionaries>
  </dictionaries>
  <files>
   </files>
  <branding>
  </branding>
</itop_design>

[rquetiez]

Method name too vague and comment are somewhat cryptic to me.
Need some dialog to find how to name and describe things.

[rquetiez]

Method name too vague and comment are somewhat cryptic to me.
Need some dialog to find how to name and describe things.

[Copilot]

Pull request overview

Fixes the “dynamic readonly/read-write” behavior during form submission by allowing GetAttributeFlags() logic to rely on posted values (not only persisted ones), so fields that become writable/readonly based on in-form changes are handled correctly.

Changes:

• Add storage of posted form values on cmdbAbstractObject and helper methods to read “current value in screen” / detect “modified in screen”.
• Populate the stored posted values during UpdateObjectFromPostedForm() so flag computation can use them.
• Adjust when ormLinkSet::UpdateFromCompleteList() emits a deprecated usage warning.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
core/ormlinkset.class.inc.php	Changes the context gating for the deprecated “old linkedset persistence pattern” warning.
application/cmdbabstract.class.inc.php	Stores posted values and adds helpers intended for dynamic GetAttributeFlags() computations during form submission.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Same as above: the doc references “GetAttributeFlag” (singular / different casing) which doesn’t match the actual GetAttributeFlags() method name. Please fix the wording so integrators know which hook this is intended for.

[Copilot]

Minor doc/casing issue: comment says “getAttributeFlag” but the method is GetAttributeFlags() (and this assignment is used before calling it). Please align wording for clarity.

Suggested change

	$this->aPostedValues = $aValues; // Store the values for later use (e.g. in getAttributeFlag)
	$this->aPostedValues = $aValues; // Store the values for later use (e.g. in GetAttributeFlags())

[Copilot]

The deprecation notification condition changed from “log everywhere except setup” to “log only in portal/console”. This significantly reduces visibility of this deprecated API usage in other contexts (REST/cron/custom scripts) and isn’t mentioned in the PR description; please confirm this behavior change is intended (or restore the previous !TAG_SETUP gating).

[Copilot]

Indentation of this new property/docblock doesn’t follow the surrounding convention in this file (tabs). Also the doc refers to “GetAttributeFlag” but the actual API is GetAttributeFlags() / GetFormAttributeFlags(); please update the wording to avoid confusion.

[Copilot]

The PHPDoc is misleading: this method doesn’t “test” anything nor compare to an “expected value”; it returns the posted value (if any) or the object’s current value. Please rewrite the doc to match behavior (and reference GetAttributeFlags() with the correct name).

[Copilot]

PR description / example mentions using $this->GetCurrentValue('status'), but the new helper is named GetCurrentValueInScreen(). To make the documented usage work and keep the API intuitive, consider adding a GetCurrentValue() alias (or renaming this method) and updating references accordingly.