Skip to content

N°8210 - Remove iApplicationObjectExtension#737

Merged
bdalsass merged 6 commits intodevelopfrom
feature/8210_remove_iapplicationobjectextension
Sep 5, 2025
Merged

N°8210 - Remove iApplicationObjectExtension#737
bdalsass merged 6 commits intodevelopfrom
feature/8210_remove_iapplicationobjectextension

Conversation

@bdalsass
Copy link
Contributor

Base information

Question Answer
Related to a Combodo ticket? N°8210 - Remove iApplicationObjectExtension
Type of change? Enhancement

Symptom (bug) / Objective (enhancement)

Remove old CRUD listening mechanism and update usage to new event system.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

@bdalsass bdalsass added this to the 3.3.0 milestone Aug 20, 2025
@bdalsass bdalsass self-assigned this Aug 20, 2025
@bdalsass bdalsass added the internal Work made by Combodo label Aug 20, 2025
@bdalsass bdalsass requested review from eespie and rquetiez August 27, 2025 07:18
- add ability to mark an object as modified
Copy link
Member

@eespie eespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@Hipska
Copy link
Contributor

Hipska commented Aug 27, 2025

Wait, this means next version will be iTop 4.0? (since removing something that has been deprecated in 3.1)

* Override the default modification state of the object.
*
* The object is considered as modified, whatever the actual state is.
* This is used when an object is modified indirectly (eg. through a linked set)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be used within a listener, when a module extends the state of a persistent object (for instance, attachments stored as a link set that cannot be modelized by an attribute)

}

public function OnIsModified($oObject)
public function RegisterEventsAndListeners() : void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the OnIsModified hook could be abandonned without regressing on the following use case: open an existing ticket, add an attachnement and click on the update button. The attachement should then be recorded. Do you confirm this behavior has been maintained?

@jf-cbd
Copy link
Member

jf-cbd commented Sep 4, 2025

Wait, this means next version will be iTop 4.0? (since removing something that has been deprecated in 3.1)

Hey @Hipska, no, next version will be 3.3 (even if, indeed, iApplicationObjectExtension was deprecated in 3.1)
For more details about migration, you can read the following doc : https://www.itophub.io/wiki/page?id=latest:customization:event#migrating_from_iapplicationobjectextension_to_listeners

…e_iapplicationobjectextension

# Conflicts:
#	application/applicationextension.inc.php
@bdalsass bdalsass merged commit 44972f3 into develop Sep 5, 2025
@bdalsass bdalsass deleted the feature/8210_remove_iapplicationobjectextension branch September 5, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants