N°8699 - attributedef.class.inc.php to PSR4#748
Merged
Conversation
bdalsass
force-pushed
the
feature/8699_attributedef_PSR4
branch
3 times, most recently
from
5e7372f to
f1d53e1
Compare
- Duplicates attributedef.class.inc.php as attributedefrequires.class.inc.php (will contains the require_once directives) - Duplicates attributedef.class.inc.php for each final class files AttributeApplicationLanguage.php, AttributeArchiveDate.php... to keep VCS history - Remove attributedef.class.inc.php file
- Restore attributedef.class.inc.php with requires - Update each attribute file code
bdalsass
force-pushed
the
feature/8699_attributedef_PSR4
branch
from
f1d53e1 to
a2c34fc
Compare
Contributor
|
Won't this conflict with #741? Also, all new files don't have an EOL on the latest line, see the ⛔ symbol in GitHub: |
- Add namespaces - Add use statements - reformat code
bdalsass
force-pushed
the
feature/8699_attributedef_PSR4
branch
from
a2c34fc to
041c30d
Compare
accognet
approved these changes
Sep 12, 2025
Contributor
|
Too bad all these files are now added to the repo with missing EOL 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Symptom (bug) / Objective (enhancement)
Attribute definition in PSR4 format
Checklist before requesting a review