N°4058 - Setup failed when added an encrypted field due to default value NULL non SODIUM compatible

core/simplecrypt.class.inc.php

@@ -130,7 +130,15 @@ function Encrypt($key, $sString)
      */
     function Decrypt($key, $string)
     {
-        return $this->oEngine->Decrypt($key,$string);
+		try{
+			return $this->oEngine->Decrypt($key,$string);
+		} catch(\Exception $e){
+			if (strlen($string)==0){
+				IssueLog::Error("Cannot decrypt empty/null value", null, ['msg' => $e->getMessage(), 'stack' => $e->getTraceAsString()]);
+				return $string;
+			}
+			throw $e;
+		}
     }
 
     /**

tests/php-unit-tests/unitary-tests/core/SympleCryptTest.php

@@ -0,0 +1,36 @@
+<?php
+/*!
+ * @copyright   Copyright (C) 2010-2024 Combodo SAS
+ * @license     http://opensource.org/licenses/AGPL-3.0
+ */
+
+namespace Combodo\iTop\Test\UnitTest\Core;
+
+use Combodo\iTop\Test\UnitTest\ItopDataTestCase;
+use SodiumException;
+
+/**
+ * Tests of the ormPassword class
+ */
+class SympleCryptTest extends ItopDataTestCase
+{
+	public function testDecryptWithNullValue()
+	{
+		$oSimpleCrypt = new \SimpleCrypt("Sodium");
+		$this->assertEquals(null, $oSimpleCrypt->Decrypt("dd", null));
+	}
+
+	public function testDecryptWithEmptyValue()
+	{
+		$oSimpleCrypt = new \SimpleCrypt("Sodium");
+		$this->assertEquals('', $oSimpleCrypt->Decrypt("dd", ""));
+	}
+
+	public function testDecrypNonDecryptableValue()
+	{
+		$this->expectException(SodiumException::class);
+		$oSimpleCrypt = new \SimpleCrypt("Sodium");
+		$this->assertEquals('', $oSimpleCrypt->Decrypt("dd", "gabuzomeu"));
+	}
+
+}