Skip to content

Conversation

@steffunky
Copy link
Member

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket? N°7939
Type of change? Bug fix

Symptom (bug)

When there's more than 2 attribute log in a class, the display is broken
image

Reproduction procedure (bug)

Add more caselog attribute to a class, open the activity panel

    <class id="UserRequest">
      <fields>
        <field id="public_log2" xsi:type="AttributeCaseLog" _delta="define">
          <sql>public_log2</sql>
          <default_value/>
          <is_null_allowed>true</is_null_allowed>
        </field>
        <field id="public_log3" xsi:type="AttributeCaseLog" _delta="define">
          <sql>public_log3</sql>
          <default_value/>
          <is_null_allowed>true</is_null_allowed>
        </field>
        <field id="public_log4" xsi:type="AttributeCaseLog" _delta="define">
          <sql>public_log4</sql>
          <default_value/>
          <is_null_allowed>true</is_null_allowed>
        </field>
        <field id="public_log5" xsi:type="AttributeCaseLog" _delta="define">
          <sql>public_log5</sql>
          <default_value/>
          <is_null_allowed>true</is_null_allowed>
        </field>
      </fields>
      <presentation>
        <details>
          <items>
            <item id="public_log2" _delta="define">
              <rank>55</rank>
            </item>
            <item id="public_log3" _delta="define">
              <rank>56</rank>
            </item>
            <item id="public_log4" _delta="define">
              <rank>57</rank>
            </item>
            <item id="public_log5" _delta="define">
              <rank>58</rank>
            </item>
          </items>
        </details>
      </presentation>
    </class>

Proposed solution (bug and enhancement)

This PR adds a scroll to the tab toggler toolbar. It also makes sure that if a caselog tab is specified in the url, the toolbar is scrolled so that the current tab toggler is visible

image

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Oct 27, 2025
@steffunky steffunky changed the base branch from develop to support/3.2 October 27, 2025 11:14
@steffunky steffunky merged commit adfa800 into support/3.2 Oct 30, 2025
1 of 2 checks passed
@steffunky steffunky deleted the features/7939_activity_tab_toggler branch October 30, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants