Skip to content

N°8891 - feat(DBObject): Add CopyIfNull() helper to copy attribute only if target is null #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
favincen wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

N°8891 - feat(DBObject): Add CopyIfNull() helper to copy attribute only if target is null #771

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ce3ea4
Add helper to copy attribute only if target is null
favincen Oct 30, 2025
1f87206
improve header
favincen Oct 30, 2025
0c8ba74
refactoring using SetIfNull()
favincen Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions core/dbobject.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,12 +762,7 @@ public function SetIfNull($sAttCode, $value)
*/
public function CopyIfNull($sDestAttCode, $sSourceAttCode)
{
$oAttDef = MetaModel::GetAttributeDef(get_class($this), $sDestAttCode);
$oCurrentValue = $this->Get($sDestAttCode);
if ($oAttDef->IsNull($oCurrentValue))
{
return $this->Copy($sDestAttCode, $sSourceAttCode);
}
$this->SetIfNull($sDestAttCode, $this->Get($sSourceAttCode));
return true;
Copy link
Contributor Author

@favincen favincen Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to Combodo: Set() and Copy() do return true unconditionaly upon completion, but SetIfNul() do not return any value. Seems unconsistant to me.
So how do this new CopyIfNull() method should behave concerning returning value ?

Copy link
Contributor Author

@favincen favincen Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should SetIfNull() be updated to return a boolean upon completion ?

}

Expand Down