N°8692 - Notification - placeholder attributesubitem#778
Open
accognet wants to merge 7 commits intosupport/3.2from
Open
N°8692 - Notification - placeholder attributesubitem#778accognet wants to merge 7 commits intosupport/3.2from
accognet wants to merge 7 commits intosupport/3.2from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes formatting of StopWatch deadline subitems when the raw value is provided as a numeric string (notably for notification placeholders).
Changes:
- Update
AttributeStopWatch::GetSubItemAsPlainText()to accept numeric-string timestamps and cast them before callingdate(). - Add a PHPUnit test covering StopWatch deadline display formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/php-unit-tests/unitary-tests/core/AttributeDefinitionTest.php | Adds a unit test asserting the plain-text rendering of a StopWatch deadline subitem. |
| core/attributedef.class.inc.php | Makes StopWatch “deadline” subitem plain-text rendering tolerant to numeric-string timestamps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/php-unit-tests/unitary-tests/core/AttributeDefinitionTest.php
Outdated
Show resolved
Hide resolved
tests/php-unit-tests/unitary-tests/core/AttributeDefinitionTest.php
Outdated
Show resolved
Hide resolved
tests/php-unit-tests/unitary-tests/core/AttributeDefinitionTest.php
Outdated
Show resolved
Hide resolved
accognet
force-pushed
the
feature/8692-placeholder_attributesubitem
branch
from
14fdc00 to
058e0b2
Compare
rquetiez
requested changes
Mar 9, 2026
tests/php-unit-tests/unitary-tests/core/AttributeSubItemTest.php
Outdated
Show resolved
Hide resolved
tests/php-unit-tests/unitary-tests/core/AttributeSubItemTest.php
Outdated
Show resolved
Hide resolved
tests/php-unit-tests/unitary-tests/core/AttributeSubItemTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Romain Quetiez <romain.quetiez@combodo.com>
Co-authored-by: Romain Quetiez <romain.quetiez@combodo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal