Skip to content

N°9340 - fix: Align FiberChannelInterface and LogicalInterface with PhysicalInterface naming#784

Merged
jf-cbd merged 2 commits intoCombodo:developfrom
Super-Visions:feat/interface/naming
Mar 11, 2026
Merged

N°9340 - fix: Align FiberChannelInterface and LogicalInterface with PhysicalInterface naming#784
jf-cbd merged 2 commits intoCombodo:developfrom
Super-Visions:feat/interface/naming

Conversation

@Hipska
Copy link
Contributor

@Hipska Hipska commented Dec 8, 2025

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N/A
Type of change? Translations

Objective

Align the naming of FiberChannelInterface and LogicalInterface interfaces to be consistent with PhysicalInterface naming. This will make ordering more logical when listing network interfaces.

Proposed solution

Add missing dictionary entries.

No unit test as it are just dictionary items.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

Copy link
Contributor

@xtophe38 xtophe38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense.

@jf-cbd
Copy link
Member

jf-cbd commented Feb 27, 2026

Accepted in functional review.
To make it easier to review, would it be possible to add before/after screenshots or description please ?

@jf-cbd jf-cbd moved this from First review needed to Pending technical review in Combodo PRs dashboard Feb 27, 2026
@jf-cbd jf-cbd changed the title fix: Align FiberChannelInterface and LogicalInterface with PhysicalInterface naming N°9340 - fix: Align FiberChannelInterface and LogicalInterface with PhysicalInterface naming Feb 27, 2026
@Hipska
Copy link
Contributor Author

Hipska commented Feb 27, 2026

Well, the naming will be Device Interface instead of Interface Device.

@Hipska
Copy link
Contributor Author

Hipska commented Mar 2, 2026

Also resolved the conflict..

# Conflicts:
#	datamodels/2.x/itop-virtualization-mgmt/dictionaries/en.dict.itop-virtualization-mgmt.php
@Hipska Hipska force-pushed the feat/interface/naming branch from 36e8e67 to 703a1c8 Compare March 11, 2026 10:47
@Hipska
Copy link
Contributor Author

Hipska commented Mar 11, 2026

@Lenaick Please don't force push develop or the support branches, this fucks up other people's work.

@Molkobain
Copy link
Contributor

Molkobain commented Mar 11, 2026

@Lenaick Please don't force push develop or the support branches, this fucks up other people's work.

This was clearly a mistake as we forbid to force-push on develop|support/x.x branches :/
We are actually looking into protecting these branches to avoid this.

@jf-cbd jf-cbd merged commit a36a7cc into Combodo:develop Mar 11, 2026
@github-project-automation github-project-automation bot moved this from Pending technical review to Finished in Combodo PRs dashboard Mar 11, 2026
@jf-cbd
Copy link
Member

jf-cbd commented Mar 11, 2026

Thanks @Hipska for your contribution :)

@Lenaick
Copy link
Contributor

Lenaick commented Mar 11, 2026

@Hipska Sorry, that was my mistake :/ I must not have been paying attention when processing my branches with my IDE... I'll be more careful !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants