N°9009 Add phpunit test to GetSelectedModules #792
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -559,4 +559,99 @@ private static function GetStep($index) | |
|
|
||
| return $aSteps[$index] ?? null; | ||
| } | ||
|
|
||
| public function ProviderGetSelectedModules() | ||
| { | ||
| return [ | ||
| 'No extension selected' => [ | ||
|
Contributor
There was a problem hiding this comment. I wonder : do we have other cases with different conditions and same result? How about having test cases with exclusive options ? |
||
| 'aSelected' => [], | ||
| 'aExpectedModules' => [], | ||
| 'aExpectedExtensions' => [], | ||
| ], | ||
| 'One extension selected' => [ | ||
|
Contributor
There was a problem hiding this comment. Independently from the implementation, we should have tests scenarios with multiple extensions selected |
||
| 'aSelected' => ['_0' => '_0'], | ||
| 'aExpectedModules' => ['combodo-sample-module' => true], | ||
| 'aExpectedExtensions' => ['combodo-sample'], | ||
| ], | ||
| ]; | ||
| } | ||
Timmy38 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * @dataProvider ProviderGetSelectedModules | ||
| */ | ||
| public function testGetSelectedModules($aSelectedExtensions, $aExpectedModules, $aExpectedExtensions) | ||
| { | ||
| $aExtensionsMapData = [ | ||
| 'combodo-sample' => [ | ||
| 'installed' => false, | ||
| ], | ||
| ]; | ||
| $this->oStep->setExtensionMap(iTopExtensionsMapFake::createFromArray($aExtensionsMapData, )); | ||
|
||
|
|
||
| //GetSelectedModules | ||
| $aStepInfo = [ | ||
| 'title' => 'Extensions', | ||
| 'description' => '', | ||
| 'banner' => '', | ||
| 'options' => [ | ||
| [ | ||
| 'extension_code' => 'combodo-sample', | ||
| 'title' => 'Sample extension', | ||
| 'description' => '', | ||
| 'more_info' => '', | ||
| 'default' => true, | ||
| 'modules' => [ | ||
| 'combodo-sample-module', | ||
| ], | ||
| 'mandatory' => false, | ||
| 'source_label' => '', | ||
| 'uninstallable' => true, | ||
| 'missing' => false, | ||
| ], | ||
| ], | ||
| ]; | ||
|
|
||
| $aModules = []; | ||
| $aExtensions = []; | ||
| $this->oStep->GetSelectedModules($aStepInfo, $aSelectedExtensions, $aModules, '', '', $aExtensions); | ||
| $this->assertEquals($aExpectedModules, $aModules); | ||
| $this->assertEquals($aExpectedExtensions, $aExtensions); | ||
| } | ||
|
|
||
| public function testGetSelectedModulesShouldThrowAnExceptionWhenAnySelectedExtensionDoesNotHaveAnyAssociatedModules() | ||
| { | ||
| $aExtensionsMapData = [ | ||
| 'combodo-sample' => [ | ||
| 'installed' => false, | ||
| ], | ||
| ]; | ||
| $this->oStep->setExtensionMap(iTopExtensionsMapFake::createFromArray($aExtensionsMapData, )); | ||
|
||
|
|
||
| //GetSelectedModules | ||
| $aStepInfo = [ | ||
| 'title' => 'Extensions', | ||
| 'description' => '', | ||
| 'banner' => '', | ||
| 'options' => [ | ||
| [ | ||
| 'extension_code' => 'combodo-sample', | ||
| 'title' => 'Sample extension', | ||
| 'description' => '', | ||
| 'more_info' => '', | ||
| 'default' => true, | ||
| 'modules' => [], | ||
| 'mandatory' => false, | ||
| 'source_label' => '', | ||
| 'uninstallable' => true, | ||
| 'missing' => false, | ||
| ], | ||
| ], | ||
| ]; | ||
|
|
||
| $aModules = []; | ||
| $aExtensions = []; | ||
| $this->expectException('Exception'); | ||
Timmy38 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| $this->oStep->GetSelectedModules($aStepInfo, ['_0' => '_0'], $aModules, '', '', $aExtensions); | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message 'Setup option does not have any module associated' could be more helpful by including which extension or choice caused the error. Consider adding the extension code or choice title to the error message to help users identify the problematic configuration more easily.