Skip to content

N°8681 - PHP 8.1: Fix deprecated notice for null value passed to preg_match_all() #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Molkobain merged 3 commits into from
Feb 16, 2026
Merged

N°8681 - PHP 8.1: Fix deprecated notice for null value passed to preg_match_all() #803

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6f732e
N°8681 - PHP 8.1: Fix deprecated notice for null value passed to preg…
Molkobain Feb 15, 2026
f6f94da
N°8681 - Add unit tests
Molkobain Feb 15, 2026
1823e8a
N°8681 - Add unit tests
Molkobain Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/attributedef.class.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4259,6 +4259,9 @@ public function GetMaxSize()

public static function RenderWikiHtml($sText, $bWikiOnly = false)
{
// N°8681 - Ensure to have a string value
$sText = $sText ?? '';

if (!$bWikiOnly) {
$sPattern = '/'.str_replace('/', '\/', utils::GetConfig()->Get('url_validation_pattern')).'/i';
if (preg_match_all(
Expand Down
3 changes: 3 additions & 0 deletions core/inlineimage.class.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,9 @@ public static function OnFormCancel($sTempId): bool
*/
public static function FixUrls($sHtml)
{
// N°8681 - Ensure to have a string value
$sHtml = $sHtml ?? '';

$aNeedles = [];
$aReplacements = [];
// Find img tags with an attribute data-img-id
Expand Down