N°8933 - Change password default length by bdalsass · Pull Request #806 · Combodo/iTop

bdalsass · 2026-02-18T07:53:23Z

Base information

Question	Answer
Related to a SourceForge thread / Another PR / Combodo ticket?
Type of change?	Bug fix

Symptom (bug) / Objective (enhancement)

Change password default length

Copilot

Pull request overview

Updates the authent-local module’s default password policy to require 12+ characters and aligns the user-facing validation messages across most locales.

Changes:

Increased default password validation regex minimum length from 8 to 12 characters.
Updated localized default error messages to say “at least 12 characters” (multiple dictionaries).
Performed dictionary formatting/alignment changes in the touched locale files.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
datamodels/2.x/authent-local/datamodel.authent-local.xml	Raises default password regex minimum length to 12.
datamodels/2.x/authent-local/dictionaries/en.dict.authent-local.php	Updates EN default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/en_gb.dict.authent-local.php	Updates EN-GB default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/fr.dict.authent-local.php	Updates FR default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/de.dict.authent-local.php	Updates DE default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/es_cr.dict.authent-local.php	Updates ES-CR default validation message to 12 chars (plus header/order + alignment changes).
datamodels/2.x/authent-local/dictionaries/it.dict.authent-local.php	Updates IT default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/nl.dict.authent-local.php	Updates NL default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/pl.dict.authent-local.php	Updates PL default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/pt_br.dict.authent-local.php	Updates PT-BR default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/ru.dict.authent-local.php	Updates RU default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/cs.dict.authent-local.php	Updates CS default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/da.dict.authent-local.php	Updates DA default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/hu.dict.authent-local.php	Updates HU default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/ja.dict.authent-local.php	Updates JA default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/sk.dict.authent-local.php	Updates SK default validation message to 12 chars (plus alignment changes).
datamodels/2.x/authent-local/dictionaries/tr.dict.authent-local.php	Updates TR default validation message to 12 chars (plus alignment changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-18T08:16:15Z

datamodels/2.x/authent-local/dictionaries/sk.dict.authent-local.php

-	'UserLocal:password:expiration' => 'The fields below require an extension~~',
-	'Class:UserLocal/Error:OneTimePasswordChangeIsNotAllowed' => 'Setting password expiration to "One-time password" is not allowed for your own User~~',
+	'Class:UserLocal'                                                           => ITOP_APPLICATION_SHORT.' užívateľ',
+	'Class:UserLocal+'                                                          => 'User authentified by '.ITOP_APPLICATION_SHORT.'~~',


Spelling: "authentified" should be "authenticated" in this (currently English) label.

Suggested change

'Class:UserLocal+' => 'User authentified by '.ITOP_APPLICATION_SHORT.'~~',

'Class:UserLocal+' => 'User authenticated by '.ITOP_APPLICATION_SHORT.'~~',

datamodels/2.x/authent-local/datamodel.authent-local.xml

Copilot · 2026-02-18T08:16:16Z

datamodels/2.x/authent-local/dictionaries/tr.dict.authent-local.php

-	'UserLocal:password:expiration' => 'The fields below require an extension~~',
-	'Class:UserLocal/Error:OneTimePasswordChangeIsNotAllowed' => 'Setting password expiration to "One-time password" is not allowed for your own User~~',
+	'Class:UserLocal'                                                           => ITOP_APPLICATION_SHORT.' kullanıcısı',
+	'Class:UserLocal+'                                                          => 'Yetki kontorlünü '.ITOP_APPLICATION_SHORT.' tarafından yapılan kullanıcı',


The Turkish translation for "Class:UserLocal+" contains a typo ("kontorlünü"), which will be displayed in the UI. Please correct the spelling (likely "kontrolünü").

Suggested change

'Class:UserLocal+' => 'Yetki kontorlünü '.ITOP_APPLICATION_SHORT.' tarafından yapılan kullanıcı',

'Class:UserLocal+' => 'Yetki kontrolünü '.ITOP_APPLICATION_SHORT.' tarafından yapılan kullanıcı',

Copilot · 2026-02-18T08:16:16Z

datamodels/2.x/authent-local/dictionaries/es_cr.dict.authent-local.php

+	'Class:UserLocal/Attribute:password_renewed_date+'                          => 'Cuando fue el último cambio de contraseña',
+	'Error:UserLocalPasswordValidator:UserPasswordPolicyRegex:ValidationFailed' => 'La contraseña debe ser de al menos 12 caracteres e incluír mayúsculas, minúsculas, números y caracteres especiales.',
+	'UserLocal:password:expiration'                                             => 'El siguiente campo requiere una extensión',
+	'Class:UserLocal/Error:OneTimePasswordChangeIsNotAllowed'                   => 'Configurar expiración de contraseña para "ontraseña de un solo uso" no está permitido para su propio Usuario',


This Spanish string contains a typo in "Contraseña" (missing the initial "C"), which will be visible in the UI. Please correct it.

Suggested change

'Class:UserLocal/Error:OneTimePasswordChangeIsNotAllowed' => 'Configurar expiración de contraseña para "ontraseña de un solo uso" no está permitido para su propio Usuario',

'Class:UserLocal/Error:OneTimePasswordChangeIsNotAllowed' => 'Configurar expiración de contraseña para "Contraseña de un solo uso" no está permitido para su propio Usuario',

datamodels/2.x/authent-local/dictionaries/es_cr.dict.authent-local.php

Copilot · 2026-02-18T08:16:17Z

datamodels/2.x/authent-local/dictionaries/en.dict.authent-local.php

-	'Class:UserLocal+' => 'User authentified by '.ITOP_APPLICATION_SHORT,
-	'Class:UserLocal/Attribute:password' => 'Password',
+	'Class:UserLocal'                     => ITOP_APPLICATION_SHORT.' user',
+	'Class:UserLocal+'                    => 'User authentified by '.ITOP_APPLICATION_SHORT,


Spelling: "authentified" should be "authenticated" in this English UI label.

Suggested change

'Class:UserLocal+' => 'User authentified by '.ITOP_APPLICATION_SHORT,

'Class:UserLocal+' => 'User authenticated by '.ITOP_APPLICATION_SHORT,

Copilot · 2026-02-18T08:16:17Z

datamodels/2.x/authent-local/dictionaries/en_gb.dict.authent-local.php

-	'Class:UserLocal+' => 'User authentified by '.ITOP_APPLICATION_SHORT,
-	'Class:UserLocal/Attribute:password' => 'Password',
+	'Class:UserLocal'                     => ITOP_APPLICATION_SHORT.' user',
+	'Class:UserLocal+'                    => 'User authentified by '.ITOP_APPLICATION_SHORT,


Spelling: "authentified" should be "authenticated" in this English UI label.

Suggested change

'Class:UserLocal+' => 'User authentified by '.ITOP_APPLICATION_SHORT,

'Class:UserLocal+' => 'User authenticated by '.ITOP_APPLICATION_SHORT,

- adjust unitary test

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

bdalsass self-assigned this Feb 18, 2026

CombodoApplicationsAccount added the internal Work made by Combodo label Feb 18, 2026

bdalsass added this to the 3.2.3 milestone Feb 18, 2026

Molkobain requested a review from Copilot February 18, 2026 08:12

Copilot started reviewing on behalf of Molkobain February 18, 2026 08:12 View session

Molkobain approved these changes Feb 18, 2026

View reviewed changes

Copilot AI reviewed Feb 18, 2026

View reviewed changes

bdalsass force-pushed the feature/8933-change-password-default-length branch from d017050 to 5a3c9b5 Compare February 18, 2026 08:32

N°8933 - Change password default length

12bf16f

bdalsass force-pushed the feature/8933-change-password-default-length branch from 5a3c9b5 to 12bf16f Compare February 18, 2026 08:36

bdalsass and others added 2 commits February 18, 2026 09:38

N°8933 - Change password default length

0703469

- adjust unitary test

Apply suggestion from @Copilot

024b842

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

steffunky approved these changes Feb 18, 2026

View reviewed changes

bdalsass merged commit 807f2a8 into support/3.2 Feb 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

N°8933 - Change password default length#806

N°8933 - Change password default length#806
bdalsass merged 3 commits intosupport/3.2from
feature/8933-change-password-default-length

bdalsass commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	'Class:UserLocal+' => 'User authentified by '.ITOP_APPLICATION_SHORT.'~~',
	'Class:UserLocal+' => 'User authenticated by '.ITOP_APPLICATION_SHORT.'~~',

	'Class:UserLocal+' => 'Yetki kontorlünü '.ITOP_APPLICATION_SHORT.' tarafından yapılan kullanıcı',
	'Class:UserLocal+' => 'Yetki kontrolünü '.ITOP_APPLICATION_SHORT.' tarafından yapılan kullanıcı',

	'Class:UserLocal/Error:OneTimePasswordChangeIsNotAllowed' => 'Configurar expiración de contraseña para "ontraseña de un solo uso" no está permitido para su propio Usuario',
	'Class:UserLocal/Error:OneTimePasswordChangeIsNotAllowed' => 'Configurar expiración de contraseña para "Contraseña de un solo uso" no está permitido para su propio Usuario',

Conversation

bdalsass commented Feb 18, 2026

Base information

Symptom (bug) / Objective (enhancement)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants