Skip to content

N°7150 - Backup : on MariaDB >= 11.0.1 call mariadb-dump instead of mysqldump #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
accognet wants to merge 3 commits into
base: support/3.2
Choose a base branch
from
Open

N°7150 - Backup : on MariaDB >= 11.0.1 call mariadb-dump instead of mysqldump #825

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ecf81d
N°7150 - Backup : on MariaDB >= 11.0.1 call mariadb-dump instead of m…
accognet Feb 27, 2026
7f24bce
N°7150 - Backup : on MariaDB >= 11.0.1 call mariadb-dump instead of m…
accognet Feb 27, 2026
3c01bd2
Update setup/backup.class.inc.php
accognet Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datamodels/2.x/itop-backup/status.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function GenerateBackupsList(string $sListTitleDictKey, string $sNoRecordDictKey
//
$sMySQLBinDir = MetaModel::GetConfig()->GetModuleSetting('itop-backup', 'mysql_bindir', '');
$sMySQLBinDir = utils::ReadParam('mysql_bindir', $sMySQLBinDir, true);
$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, 'mysqldump');
$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, DBBackup::GetDumpFunction());
$sCommand = "$sMySQLDump -V 2>&1";

$aOutput = [];
Expand Down
12 changes: 11 additions & 1 deletion setup/backup.class.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ public function DoBackup($sBackupFileName)
$this->LogInfo("Starting backup of $this->sDBHost/$this->sDBName(suffix:'$this->sDBSubName')");
$sMySQLBinDir = utils::ReadParam('mysql_bindir', $this->sMySQLBinDir, true);

$sMySQLDump = $this->MakeSafeMySQLCommand($sMySQLBinDir, 'mysqldump');
$sMySQLDump = $this->MakeSafeMySQLCommand($sMySQLBinDir, DBBackup::GetDumpFunction());

// Store the results in a temporary file
$sTmpFileName = self::EscapeShellArg($sBackupFileName);
Expand Down Expand Up @@ -603,6 +603,16 @@ public static function MakeSafeMySQLCommand($sMySQLBinDir, string $sCmd)

return '"'.$sMySQLCommand.'"';
}

public static function GetDumpFunction(): string
{
$version = CMDBSource::QueryToScalar('SELECT VERSION()');
if (is_string($version) && stripos($version, 'MariaDB') !== false) {
return 'mariadb-dump';
}

return 'mysqldump';
}
}

class TarGzArchive implements BackupArchive
Expand Down
5 changes: 4 additions & 1 deletion setup/setuputils.class.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,12 +559,15 @@ public static function CheckBackupPrerequisites($sDBBackupPath, $sMySQLBinDir =
$aResult[] = new CheckResult(CheckResult::ERROR, "The PHP exec() function has been disabled on this server");
}

MetaModel::LoadConfig(utils::GetConfig());
// availability of mysqldump
if (empty($sMySQLBinDir) && null != MetaModel::GetConfig()) {
$sMySQLBinDir = MetaModel::GetConfig()->GetModuleSetting('itop-backup', 'mysql_bindir', '');
}
try {
$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, 'mysqldump');
$oConfig = MetaModel::GetConfig();
CMDBSource::InitFromConfig($oConfig);
$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, DBBackup::GetDumpFunction());
} catch (Exception $e) {
$aResult[] = new CheckResult(CheckResult::ERROR, $e->getMessage());
return $aResult;
Expand Down