Skip to content

N°9238 - Sanitize data_source_id query parameter in synchro_import script#831

Merged
Lenaick merged 1 commit intosupport/3.2from
issue/9238-reflected-xss-synchro-import-idatasourceid
Mar 9, 2026
Merged

N°9238 - Sanitize data_source_id query parameter in synchro_import script#831
Lenaick merged 1 commit intosupport/3.2from
issue/9238-reflected-xss-synchro-import-idatasourceid

Conversation

@Lenaick
Copy link
Contributor

@Lenaick Lenaick commented Mar 6, 2026

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N°9238
Type of change? Bug fix

Symptom

The data_source_id parameter in the synchro_import script accepts unsanitized input, which is reflected in the response without proper encoding

Cause

The data_source_id parameter is not sanitized before printing the error value

Proposed solution

Sanitize the data_source_id parameter

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Mar 6, 2026
@Lenaick Lenaick requested review from bdalsass and steffunky March 6, 2026 14:36
@Molkobain Molkobain added this to the 3.2.3 milestone Mar 6, 2026
@Lenaick Lenaick merged commit 9236449 into support/3.2 Mar 9, 2026
1 of 2 checks passed
@Lenaick Lenaick deleted the issue/9238-reflected-xss-synchro-import-idatasourceid branch March 9, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants